Skip to content

feat(v8): Remove deprecated span.isSuccess method #10699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2024
Merged

feat(v8): Remove deprecated span.isSuccess method #10699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/core/src/tracing/sentrySpan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,15 +497,6 @@ export class SentrySpan implements SpanInterface {
return this;
}

/**
* @inheritDoc
*
* @deprecated Use `spanToJSON(span).status === 'ok'` instead.
*/
public isSuccess(): boolean {
return this._status === 'ok';
}

/**
* @inheritDoc
*
Expand Down
25 changes: 0 additions & 25 deletions packages/tracing/test/span.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,31 +123,6 @@ describe('SentrySpan', () => {
expect(span.tags['http.status_code']).toBe('404');
expect(span.data['http.response.status_code']).toBe(404);
});

// TODO (v8): Remove
test('isSuccess', () => {
const span = new SentrySpan({});
expect(span.isSuccess()).toBe(false);
expect(spanToJSON(span).status).not.toBe('ok');
span.setHttpStatus(200);
expect(span.isSuccess()).toBe(true);
expect(spanToJSON(span).status).toBe('ok');
span.setStatus('permission_denied');
expect(span.isSuccess()).toBe(false);
expect(spanToJSON(span).status).not.toBe('ok');
span.setHttpStatus(0);
expect(span.isSuccess()).toBe(false);
expect(spanToJSON(span).status).not.toBe('ok');
span.setHttpStatus(-1);
expect(span.isSuccess()).toBe(false);
expect(spanToJSON(span).status).not.toBe('ok');
span.setHttpStatus(99);
expect(span.isSuccess()).toBe(false);
expect(spanToJSON(span).status).not.toBe('ok');
span.setHttpStatus(100);
expect(span.isSuccess()).toBe(true);
expect(spanToJSON(span).status).toBe('ok');
});
});

describe('toTraceparent', () => {
Expand Down
7 changes: 0 additions & 7 deletions packages/types/src/span.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,13 +365,6 @@ export interface Span extends Omit<SpanContext, 'op' | 'status' | 'origin'> {
*/
startChild(spanContext?: Pick<SpanContext, Exclude<keyof SpanContext, 'sampled' | 'traceId' | 'parentSpanId'>>): Span;

/**
* Determines whether span was successful (HTTP200)
*
* @deprecated Use `spanToJSON(span).status === 'ok'` instead.
*/
isSuccess(): boolean;

/**
* Return a traceparent compatible header string.
* @deprecated Use `spanToTraceHeader()` instead.
Expand Down