Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Feb 14, 2024

This was a bit inconsistent now, we sometimes stored it on the current and sometimes on the isolation scope. Fixing this to always be on the isolation scope, for consistency.

@mydea mydea requested review from Lms24 and lforst February 14, 2024 15:29
@mydea mydea self-assigned this Feb 14, 2024
@mydea
Copy link
Member Author

mydea commented Feb 14, 2024

Ah, this depends on #10658, as we otherwise don't have these re-exports in @sentry/react 😬

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.82 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.06 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.98 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.67 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.25 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.15 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.16 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.16 KB (0%)
@sentry/browser - Webpack (gzipped) 22.43 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.11 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.64 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.6 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.71 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.88 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.5 KB (+0.07% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74.01 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.83 KB (+0.04% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.43 KB (0%)
@sentry/react - Webpack (gzipped) 22.45 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.19 KB (+0.11% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.36 KB (+0.01% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.12 KB (0%)

@mydea mydea force-pushed the fn/runtime-on-isolation-scope branch from f8c9ce5 to 2652bf2 Compare February 14, 2024 16:02
This was a bit inconsistent now, we sometimes stored it on the current and sometimes on the isolation scope. Fixing this to always be on the isolation scope, for consistency.
@mydea mydea force-pushed the fn/runtime-on-isolation-scope branch from 2652bf2 to 9a572f4 Compare February 14, 2024 16:13
@mydea mydea merged commit 6361f9c into develop Feb 14, 2024
@mydea mydea deleted the fn/runtime-on-isolation-scope branch February 14, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants