Skip to content

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Feb 7, 2024

Removes all deprecated code from the Next.js package.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.16 KB (-0.22% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.37 KB (-0.29% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.31 KB (-0.25% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 63.01 KB (-0.26% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.35 KB (-0.5% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.22 KB (-0.51% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.2 KB (-0.54% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.21 KB (-0.53% 🔽)
@sentry/browser - Webpack (gzipped) 22.48 KB (-0.69% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.19 KB (-0.23% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.71 KB (-0.28% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.47 KB (-0.56% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.56 KB (-0.7% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 213.68 KB (-0.19% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.48 KB (-0.39% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.86 KB (-0.54% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.64 KB (-0.44% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.76 KB (-0.24% 🔽)
@sentry/react - Webpack (gzipped) 22.52 KB (-0.66% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.53 KB (-0.02% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.42 KB (-2.52% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.2 KB (-0.1% 🔽)

startTransactionOnLocationChange: boolean = true,
shouldInstrumentPageload: boolean,
shouldInstrumentNavigation: boolean,
startPageloadSpanCallback: StartSpanCb,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: We can refactor this later, but IMHO we can simplify this by just passing the client in here and directly calling the start span methods from core here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow ^^ Do you mind elaborating? Or do you have examples where we do something similar?

{
sentryTrace: sentryTraceHeader ?? headers?.get('sentry-trace') ?? undefined,
baggage: baggageHeader ?? headers?.get('baggage'),
sentryTrace: headers?.get('sentry-trace') ?? undefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this not the same as leaving the ?? undefined away here? (or is it bad if this returns null, not sure if this is possible) - just because we don't do it below :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit ridiculous but continueTrace doesn't take null as sentryTrace value so we need to turn it into undefined. I wanted to change that anyhow. I'll clean this up in a follow-up.

@lforst
Copy link
Contributor Author

lforst commented Feb 7, 2024

@mydea I am blocked to migrate traceparentData and tags to the scope because the current browserTracingIntegration implementation doesn't pick them up yet. I would do that in a follow-up.

@lforst lforst changed the title ref(nextjs): Remove all deprecated code ref(nextjs): Remove all deprecated API Feb 7, 2024
@lforst lforst requested review from AbhiPrasad and Lms24 February 7, 2024 16:03
@lforst lforst requested a review from mydea February 9, 2024 10:23
@lforst lforst merged commit d024a76 into develop Feb 9, 2024
@lforst lforst deleted the lforst-nextjs-rm-deprecations branch February 9, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants