Skip to content

test(browser-integration): Attempt to improve potentially flakey slowClick -> windowOpen test #10538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2024
Merged

test(browser-integration): Attempt to improve potentially flakey slowClick -> windowOpen test #10538

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f86ad8
test(browser-integration): Attempt to improve potentially flakey `slo…
billyvg Feb 6, 2024
3f366fb
lint
billyvg Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions dev-packages/browser-integration-tests/suites/replay/slowClick/windowOpen/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,14 @@ sentryTest('window.open() is considered for slow click', async ({ getLocalTestUr

// Ensure window.open() still works as expected
const context = browser.contexts()[0];
const waitForNewPage = context.waitForEvent('page');

await page.locator('#windowOpenButton').click();
const [reqResponse1] = await Promise.all([
reqPromise1,
context.waitForEvent('page'),
page.locator('#windowOpenButton').click(),
]);

const { breadcrumbs } = getCustomRecordingEvents(await reqPromise1);
const { breadcrumbs } = getCustomRecordingEvents(reqResponse1);

// Filter out potential blur breadcrumb, as otherwise this can be flaky
const filteredBreadcrumb = breadcrumbs.filter(breadcrumb => breadcrumb.category !== 'ui.blur');
Expand All @@ -57,8 +60,6 @@ sentryTest('window.open() is considered for slow click', async ({ getLocalTestUr
},
]);

await waitForNewPage;

const pages = context.pages();

expect(pages.length).toBe(2);
Expand Down