Skip to content

Conversation

@AbhiPrasad
Copy link
Member

This reverts commit 94cdd8b.

I mistakenly merged this - we have to fix the metric summaries format.

Summaries are typed as pub type MetricSummaryMapping = Object<Array<MetricSummary>>;

Which means that the _metrics_summary type needs to be _metrics_summary?: Record<string, Array<MetricSummary>>;. This is because we need to create separate entries if the tags have changed.

"c:processor.item_processed": [
    {
        "min": 1,
        "max": 1,
        "count": 3,
        "sum": 3,
        "tags": {"success": true}
    },
    {
        "min": 1,
        "max": 1,
        "count": 2,
        "sum": 2,
        "tags": {"success": false}
    }
],

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) February 5, 2024 15:31
@AbhiPrasad AbhiPrasad merged commit 60a7d65 into develop Feb 5, 2024
@AbhiPrasad AbhiPrasad deleted the revert-10432-feat/metric-summaries branch February 5, 2024 19:42
cleptric added a commit that referenced this pull request Feb 7, 2024
…10495)"

This reverts commit 60a7d65.

# Conflicts:
#	packages/types/src/event.ts
cleptric added a commit that referenced this pull request Feb 8, 2024
…10495)"

This reverts commit 60a7d65.

# Conflicts:
#	packages/types/src/event.ts
cleptric added a commit that referenced this pull request Feb 8, 2024
…10495)"

This reverts commit 60a7d65.

# Conflicts:
#	packages/types/src/event.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants