- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.7k
          feat(react): Add reactRouterV3BrowserTracingIntegration for react router v3
          #10489
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
edbe9c2    to
    7e3c69a      
    Compare
  
    browserTracingReactRouterV3IntegrationbrowserTracingReactRouterV3Integration for react router v3
              
          
                packages/react/src/index.ts
              
                Outdated
          
        
      | export { | ||
| // eslint-disable-next-line deprecation/deprecation | ||
| reactRouterV3Instrumentation, | ||
| browserTracingReactRouterV3Integration, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as in #10488, reactRouterV3BrowserTracingIntegration would sound a bit cleaner to me.
7e3c69a    to
    727ae24      
    Compare
  
    browserTracingReactRouterV3Integration for react router v3reactRouterV3BrowserTracingIntegration for react router v3
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO that's acceptable, we don't really have a from field anyhow in other instrumentations, so we may even think about removing this I'd say
Let's remove
To replace the routing instrumentation.
727ae24    to
    4bca46a      
    Compare
  
    | size-limit report 📦
 | 
To replace the routing instrumentation.
There is a small issue here, which is that we do not set the
fromattribute for the first navigation after the pageload (as technically we are calling instrument twice there...) - IMHO that's acceptable, we don't really have afromfield anyhow in other instrumentations, so we may even think about removing this I'd say...