Skip to content

fix(test): Fix flaky browser integration tests. #10484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix(test): Fix flaky browser integration tests. #10484

merged 1 commit into from
Feb 20, 2024

Conversation

@onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Feb 4, 2024 •
edited
Loading

This is not a complete fix for all flaky integration tests, but it seems to resolve flakiness of a few tests that fail very frequently.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.84 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.08 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.69 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.28 KB (-0.09% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.13 KB (-0.09% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.13 KB (-0.1% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.13 KB (-0.1% 🔽)
@sentry/browser - Webpack (gzipped) 22.41 KB (-0.13% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.81 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.37 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.33 KB (-0.14% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.43 KB (-0.21% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.34 KB (-0.13% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.97 KB (-0.2% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.38 KB (-0.27% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.56 KB (-0.18% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.44 KB (-0.08% 🔽)
@sentry/react - Webpack (gzipped) 22.44 KB (-0.13% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.26 KB (-0.07% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.38 KB (-0.07% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.1 KB (-0.03% 🔽)

@onurtemizkan onurtemizkan force-pushed the onur/fix-flaky-browser-tests branch from 7800384 to 431b019 Compare February 4, 2024 18:32
mydea
mydea reviewed Feb 5, 2024
View reviewed changes
dev-packages/browser-integration-tests/suites/stacktraces/protocol_fn_identifiers/test.ts
import { getFirstSentryEnvelopeRequest } from '../../../utils/helpers';

sentryTest(
'should parse function identifiers that are protocol names correctly @firefox',
Copy link
Member

@mydea mydea Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is here on purpose, that ensures this specific test is also run in FF :)

Copy link
Collaborator Author

@onurtemizkan onurtemizkan Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, thanks I'm reverting this 👍

@onurtemizkan onurtemizkan force-pushed the onur/fix-flaky-browser-tests branch 5 times, most recently from ba85ddb to f27e176 Compare February 6, 2024 11:41
@onurtemizkan onurtemizkan force-pushed the onur/fix-flaky-browser-tests branch 6 times, most recently from e61fb49 to 4e69aae Compare February 12, 2024 14:19
@onurtemizkan onurtemizkan force-pushed the onur/fix-flaky-browser-tests branch from 4e69aae to d36bed4 Compare February 12, 2024 14:41
@onurtemizkan onurtemizkan marked this pull request as ready for review February 12, 2024 14:41
@AbhiPrasad AbhiPrasad merged commit 18f7107 into develop Feb 20, 2024
@AbhiPrasad AbhiPrasad deleted the onur/fix-flaky-browser-tests branch February 20, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea mydea approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@onurtemizkan @mydea @AbhiPrasad