fix(test): Clean up docker containers with script #10454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
approved these changes
Feb 1, 2024
onurtemizkan
pushed a commit
that referenced
this pull request
Feb 4, 2024
This PR adds a script to cleanup any docker containers left over from the node integration tests. - It uses `globby@11` since that is already installed for a couple of our dependencies. - It finds all the `docker-compose.yml` files and runs `docker compose down --volumes` in those directories. - It catches all errors for when docker is not running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script to cleanup any docker containers left over from the node integration tests.
globby@11since that is already installed for a couple of our dependencies.docker-compose.ymlfiles and runsdocker compose down --volumesin those directories.