Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Jan 31, 2024

Saw a flake for this, we should ignore long-task spans as they are unpredictable.

Saw a flake for this, we should ignore long-task spans as they are unpredictable.
@mydea mydea requested review from Lms24 and lforst January 31, 2024 09:40
@mydea mydea self-assigned this Jan 31, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair, I believe we even have concrete integration tests for long tasks so it's still tested anyway.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.11 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.35 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.21 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.96 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.36 KB (-0.15% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.23 KB (-0.15% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.33 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.34 KB (0%)
@sentry/browser - Webpack (gzipped) 22.6 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.07 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.63 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.46 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.66 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 213.38 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.39 KB (+0.26% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.6 KB (+0.13% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.71 KB (-0.1% 🔽)
@sentry/react - Webpack (gzipped) 22.63 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.48 KB (+0.03% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.78 KB (+0.04% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)

@mydea mydea merged commit c51891b into develop Jan 31, 2024
@mydea mydea deleted the fn/unflake-ember-test branch January 31, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants