Skip to content

ci: Use larger runners for playwright tests #10417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2024
Merged

ci: Use larger runners for playwright tests #10417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
597ffed
ci: Use larger runners for playwright tests
Jan 30, 2024
bdfb543
Also beefier runner on prepare e2e tests bc it is a bottleneck
Jan 30, 2024
80d5e53
stupid test
Jan 30, 2024
0c07a75
Merge branch 'develop' into lforst-larger-runners
Jan 30, 2024
cf3aad3
larger runner for build
Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ jobs:
name: Playwright (${{ matrix.bundle }}) Tests
needs: [job_get_metadata, job_build]
if: needs.job_get_metadata.outputs.changed_browser_integration == 'true' || github.event_name != 'pull_request'
runs-on: ubuntu-20.04
runs-on: ubuntu-20.04-large-js
timeout-minutes: 25
strategy:
fail-fast: false
Expand Down Expand Up @@ -670,7 +670,7 @@ jobs:
name: Browser (${{ matrix.browser }}) Tests
needs: [job_get_metadata, job_build]
if: needs.job_get_metadata.outputs.changed_browser == 'true' || github.event_name != 'pull_request'
runs-on: ubuntu-20.04
runs-on: ubuntu-20.04-large-js
timeout-minutes: 20
strategy:
fail-fast: false
Expand Down Expand Up @@ -840,7 +840,7 @@ jobs:
(github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) &&
github.actor != 'dependabot[bot]'
needs: [job_get_metadata, job_build]
runs-on: ubuntu-20.04
runs-on: ubuntu-20.04-large-js
timeout-minutes: 15
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
Expand Down
2 changes: 1 addition & 1 deletion ...s/browser-integration-tests/suites/tracing/browserTracingIntegration/interactions/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ sentryTest('should capture interaction transaction. @firefox', async ({ browserN
expect(interactionSpan.timestamp).toBeDefined();

const interactionSpanDuration = (interactionSpan.timestamp! - interactionSpan.start_timestamp) * 1000;
expect(interactionSpanDuration).toBeGreaterThan(70);
expect(interactionSpanDuration).toBeGreaterThan(65);
expect(interactionSpanDuration).toBeLessThan(200);
});

Expand Down