Skip to content

fix(nextjs): Fix Http integration type declaration #10338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2024
Merged

fix(nextjs): Fix Http integration type declaration #10338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0807af7
fix(nextjs): Fix Http integration type declaration
Lms24 Jan 25, 2024
f025eea
same thing for OnUncaughtException integration
Lms24 Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/nextjs/src/server/httpIntegration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import { Integrations } from '@sentry/node';
const { Http: OriginalHttp } = Integrations;

/**
* A custom HTTP integration where we always enable tracing.
*/
export class Http extends OriginalHttp {
public constructor(options?: ConstructorParameters<typeof OriginalHttp>[0]) {
export class Http extends Integrations.Http {
public constructor(options?: ConstructorParameters<typeof Integrations.Http>[0]) {
super({
...options,
tracing: true,
Expand Down
5 changes: 2 additions & 3 deletions packages/nextjs/src/server/onUncaughtExceptionIntegration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import { Integrations } from '@sentry/node';
const { OnUncaughtException: OriginalOnUncaughtException } = Integrations;

/**
* A custom OnUncaughtException integration that does not exit by default.
*/
export class OnUncaughtException extends OriginalOnUncaughtException {
public constructor(options?: ConstructorParameters<typeof OriginalOnUncaughtException>[0]) {
export class OnUncaughtException extends Integrations.OnUncaughtException {
public constructor(options?: ConstructorParameters<typeof Integrations.OnUncaughtException>[0]) {
super({
exitEvenIfOtherHandlersAreRegistered: false,
...options,
Expand Down