ref(svelte): Prepare package.json config for Svelte 5 support
#10311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the title
package.json entry points for Svelte 5 supportpackage.json config for Svelte 5 support
This was referenced Jan 24, 2024
|
argh this breaks our jest test b/c of type: module 🥲 will revisit one we figured jest out |
AbhiPrasad
reviewed
Jan 24, 2024
There was a problem hiding this comment.
We're going to have a bunch of jest issues with esm in general - we might want to migrate some stuff to vitest as a result.
"types": "./build/types/index.d.ts", might cause problems for some users setups, if we use package.json exports we need index.d.cts and index.d.mts (different types for esm and cjs). This is a pain though, so we can try to avoid it.
Lms24
force-pushed
the
lms/ref-svelte-pkgjson-exports
branch
from
f4227b8 to
48d6fcc
Compare
|
Superseded by #11807, no longer necessary after our v8 ESM package.json chagnes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the
package.jsonof@sentry/svelteto support Svelte 5. Similarly to SvelteKit 2, we now need to declare the package astype: "module"and set theexportsproperty.Important: I purposefully didn't yet bump peer dependencies. Svelte 5 is still in preview and we shouldn't commit to officially supporting it. Everything we do now is only preparation work.
As far as my testing goes, I didn't find backwards compatibility issues with Svelte 4 or SvelteKit.