Skip to content

feat(browser): Deprecate BrowserTracing in favor of browserTracingIntegration #10304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2024
Merged

feat(browser): Deprecate BrowserTracing in favor of browserTracingIntegration #10304

merged 2 commits into from
Jan 24, 2024

Conversation

@mydea
Copy link
Member

@mydea mydea commented Jan 23, 2024

Step by step...

@mydea mydea requested review from AbhiPrasad, Lms24 and lforst January 23, 2024 19:56
@mydea mydea self-assigned this Jan 23, 2024
AbhiPrasad
AbhiPrasad approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need migration docs for this as well

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.78 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.96 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.85 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.59 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.98 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.25 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.26 KB (0%)
@sentry/browser - Webpack (gzipped) 22.5 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.54 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.1 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.94 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.45 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 211.35 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.35 KB (+0.06% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.14 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.01 KB (+0.03% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.39 KB (0%)
@sentry/react - Webpack (gzipped) 22.55 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.03 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.33 KB (+0.02% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)

@mydea
Copy link
Member Author

mydea commented Jan 24, 2024

We need migration docs for this as well

oops, totally forgot, added this as well!

@mydea mydea merged commit a2f0bac into develop Jan 24, 2024
@mydea mydea deleted the fn/browserTracingInstrumentation branch January 24, 2024 14:04
mydea added a commit that referenced this pull request Jan 24, 2024
@mydea
Revert "feat(browser): Deprecate BrowserTracing in favor of `browse…
dc5be1e 
…rTracingIntegration` (#10304)"

This reverts commit a2f0bac.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mydea @Lms24 @AbhiPrasad