Skip to content

Conversation

@AbhiPrasad
Copy link
Member

Wanted to test out integration changes, so decided try it with Vue integration

I'm not the biggest fan with vueIntegration vs. VueIntegration. Also I wanted to use vueIntegration in packages/vue/sdk.ts when setting default integrations but was unable to due to typing, is there a way around that?

@AbhiPrasad AbhiPrasad requested review from lforst and mydea January 17, 2024 14:54
@AbhiPrasad AbhiPrasad self-assigned this Jan 17, 2024
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.37 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.67 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.31 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.67 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.13 KB (0%)
@sentry/browser - Webpack (gzipped) 22.48 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.63 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.48 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.19 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 209.91 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 97.89 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 72.34 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.49 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.06 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped) 22.52 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.68 KB (+0.03% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.81 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.11 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.48 KB (added)

@mydea
Copy link
Member

mydea commented Jan 17, 2024

Also I wanted to use vueIntegration in packages/vue/sdk.ts when setting default integrations but was unable to due to typing, is there a way around that?

Not sure, but I opted (so far) to keep the class instances everywhere where we've had them before, although it probably isn't necessary actually. What error are you getting? 🤔 I 'd think that it should be working, but 🤷

@AbhiPrasad AbhiPrasad merged commit ba9999f into develop Jan 17, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-vue-integration-deprecate branch January 17, 2024 19:37
@AbhiPrasad
Copy link
Member Author

Not sure, but I opted (so far) to keep the class instances everywhere where we've had them before, although it probably isn't necessary actually. What error are you getting? 🤔 I 'd think that it should be working, but 🤷

Oh wait it does work, I should have swapped it, let me make a quick follow up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants