Skip to content

test: fix node.js integration tests #10204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2024
Merged

test: fix node.js integration tests #10204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f61dda4
test: fix node.js integration tests
anonrig Jan 16, 2024
2d76a27
fix linting error
anonrig Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dev-packages/node-integration-tests/suites/express/tracing-experimental/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ conditionalTest({ min: 14 })('express tracing experimental', () => {
op: 'http.server',
status: 'ok',
tags: {
'http.status_code': 200,
'http.status_code': '200',
},
},
},
Expand Down Expand Up @@ -63,7 +63,7 @@ conditionalTest({ min: 14 })('express tracing experimental', () => {
op: 'http.server',
status: 'ok',
tags: {
'http.status_code': 200,
'http.status_code': '200',
},
},
},
Expand Down Expand Up @@ -95,7 +95,7 @@ conditionalTest({ min: 14 })('express tracing experimental', () => {
op: 'http.server',
status: 'ok',
tags: {
'http.status_code': 200,
'http.status_code': '200',
},
},
},
Expand Down Expand Up @@ -135,7 +135,7 @@ conditionalTest({ min: 14 })('express tracing experimental', () => {
op: 'http.server',
status: 'ok',
tags: {
'http.status_code': 200,
'http.status_code': '200',
},
},
},
Expand Down
2 changes: 1 addition & 1 deletion packages/core/test/lib/scope.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ describe('withActiveSpan()', () => {
const client = new TestClient(options);
const scope = new Scope();
const hub = new Hub(client, scope);
makeMain(hub);
makeMain(hub); // eslint-disable-line deprecation/deprecation
});

it('should set the active span within the callback', () => {
Expand Down