feat(core): Deprecate integration classes & Integrations.X
#10198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Jan 16, 2024
packages/bun/src/index.ts
Outdated
Comment on lines
82
to
85
| moduleMetadataIntegration, | ||
| requestDataIntegration, |
Member
Author
There was a problem hiding this comment.
Do we want to export these here? Previously, these were not accessible directly from @sentry/bun.
Member
There was a problem hiding this comment.
Not moduleMetadataIntegration, but we might want requestDataIntegration.
Member
Author
There was a problem hiding this comment.
OK, I guess we may move the moduleMetadatIntegation to browser in v8? 🤔 if this is browser-only, no need to have & export it from core. But we can see!
Member
Author
There was a problem hiding this comment.
or actually, maybe I move it there right away 🤔
mydea
commented
Jan 16, 2024
packages/deno/src/index.ts
Outdated
| metrics, | ||
| inboundFiltersIntegration, | ||
| linkedErrorsIntegration, | ||
| moduleMetadataIntegration, |
Member
Author
There was a problem hiding this comment.
Do we want to export this * requestDataIntegration here? Previously, these were not accessible directly from @sentry/deno.
mydea
commented
Jan 16, 2024
packages/node/src/index.ts
Outdated
| functionToStringIntegration, | ||
| inboundFiltersIntegration, | ||
| linkedErrorsIntegration, | ||
| moduleMetadataIntegration, |
Member
Author
There was a problem hiding this comment.
Do we want to export this here? Previously, this was not accessible directly from @sentry/node.
mydea
commented
Jan 16, 2024
packages/vercel-edge/src/index.ts
Outdated
Comment on lines
81
to
84
| moduleMetadataIntegration, | ||
| requestDataIntegration, |
Member
Author
There was a problem hiding this comment.
Do we want to export these here? Previously, these were not accessible directly from `@sentry/vercel-edge.
mydea
force-pushed
the
fn/core-integrations
branch
from
f4cbdea to
55d14e6
Compare
Contributor
size-limit report 📦
|
mydea
force-pushed
the
fn/core-integrations
branch
from
55d14e6 to
3593de1
Compare
Instead, export the functional components from core, which users should directly use.
mydea
force-pushed
the
fn/core-integrations
branch
from
3593de1 to
6659c7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, export the functional components from core, which users should directly use.
This also adds a tiny
defineIntegrationutility which takes care of obscuring the actual integration implementation for external use, so this remains private and we can refactor this if we need to.