ref(core): Add missing class field deprecations #10187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fields were alredy deprecated on the interface, this patch only adds the deprecation annotation to the JSDoc of the class fields. After testing with eslint, linters will correctly infer the deprecation status. VSCode also shows the fields as deprecated in the JSDoc but doesn't apply the strikethrough. So for extra clarity, let's also deprecate the class fields here.
mydea
reviewed
Jan 15, 2024
mydea
approved these changes
Jan 15, 2024
Co-authored-by: Francesco Novy <[email protected]>
Contributor
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some
@deprecatedannotations to already deprecated Span APIs:Span.toTraceParent()Span.toContext()Span.updateWithContext()Span.getTraceContext()These fields were already deprecated on the interface, this patch only adds the deprecation annotation to the JSDoc of the class fields.
When testing with eslint, it will correctly infer the deprecation status from the interface. VSCode also shows the fields as deprecated in the JSDoc but doesn't apply the strikethrough. So for extra clarity, let's also deprecate the class fields here.
ref #10184