Skip to content

fix(node-experimental): Ensure http.status_code is always a string #10177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix(node-experimental): Ensure http.status_code is always a string #10177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...kages/e2e-tests/test-applications/node-experimental-fastify-app/tests/propagation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ test('Propagates trace for outgoing http requests', async ({ baseURL }) => {
span_id: expect.any(String),
status: 'ok',
tags: {
'http.status_code': 200,
'http.status_code': '200',
},
trace_id: traceId,
origin: 'auto.http.otel.http',
Expand All @@ -91,7 +91,7 @@ test('Propagates trace for outgoing http requests', async ({ baseURL }) => {
span_id: expect.any(String),
status: 'ok',
tags: {
'http.status_code': 200,
'http.status_code': '200',
},
trace_id: traceId,
origin: 'auto.http.otel.http',
Expand Down Expand Up @@ -161,7 +161,7 @@ test('Propagates trace for outgoing fetch requests', async ({ baseURL }) => {
span_id: expect.any(String),
status: 'ok',
tags: {
'http.status_code': 200,
'http.status_code': '200',
},
trace_id: traceId,
origin: 'auto.http.otel.http',
Expand All @@ -184,7 +184,7 @@ test('Propagates trace for outgoing fetch requests', async ({ baseURL }) => {
span_id: expect.any(String),
status: 'ok',
tags: {
'http.status_code': 200,
'http.status_code': '200',
},
trace_id: traceId,
origin: 'auto.http.otel.http',
Expand Down
4 changes: 2 additions & 2 deletions ...ages/e2e-tests/test-applications/node-experimental-fastify-app/tests/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
span_id: expect.any(String),
status: 'ok',
tags: {
'http.status_code': 200,
'http.status_code': '200',
},
trace_id: expect.any(String),
origin: 'auto.http.otel.http',
Expand Down Expand Up @@ -85,7 +85,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
},
],
tags: {
'http.status_code': 200,
'http.status_code': '200',
},
transaction: 'GET /test-transaction',
type: 'transaction',
Expand Down
5 changes: 2 additions & 3 deletions packages/opentelemetry/src/spanExporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,9 +280,8 @@ function getTags(span: ReadableSpan): Record<string, string> {
const tags: Record<string, string> = {};

if (attributes[SemanticAttributes.HTTP_STATUS_CODE]) {
const statusCode = attributes[SemanticAttributes.HTTP_STATUS_CODE] as string;

tags['http.status_code'] = statusCode;
const statusCode = attributes[SemanticAttributes.HTTP_STATUS_CODE] as string | number;
tags['http.status_code'] = `${statusCode}`;
}

return tags;
Expand Down