Skip to content

Conversation

@timfish
Copy link
Collaborator

@timfish timfish commented Jan 11, 2024

This PR adds an integration that tests the proxy transport option.

To do this I've added a .withMockSentryServer() feature to the test runner.

When optionally enabled, a basic express server is started which listens with an envelope endpoint. Test scenarios can then use the SENTRY_DSN environment variable to set the correct DSN.

Why a Sentry server when we have this new stdout transport for testing?

We need to test the transport and assosiated things like the proxy option which can't use stdout parsing.

Why use the stdout transport at all if we can just use this server?

Resources when running tests in parallel?

Because they use the same test runner, it's relatively simple to migrate tests between the two, so once we have a full test suite we can test this further.

@timfish timfish marked this pull request as ready for review January 11, 2024 22:23
@timfish timfish requested a review from AbhiPrasad January 16, 2024 22:19
@AbhiPrasad AbhiPrasad merged commit 29d597f into getsentry:develop Jan 16, 2024
@timfish timfish deleted the test/node-proxy-server branch January 17, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants