Skip to content

meta: Ignore Transaction deprecation lint warnings in DSC tests #10133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2024
Merged

meta: Ignore Transaction deprecation lint warnings in DSC tests #10133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/core/test/lib/tracing/dynamicSamplingContext.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ describe('getDynamicSamplingContextFromSpan', () => {
});

test('returns the DSC provided during transaction creation', () => {
// eslint-disable-next-line deprecation/deprecation
const transaction = new Transaction({
name: 'tx',
metadata: { dynamicSamplingContext: { environment: 'myEnv' } },
Expand Down Expand Up @@ -67,6 +68,7 @@ describe('getDynamicSamplingContextFromSpan', () => {
});

test('returns a new DSC, if no DSC was provided during transaction creation (via new Txn and deprecated metadata)', () => {
// eslint-disable-next-line deprecation/deprecation
const transaction = new Transaction({
name: 'tx',
metadata: {
Expand All @@ -90,6 +92,7 @@ describe('getDynamicSamplingContextFromSpan', () => {

describe('Including transaction name in DSC', () => {
test('is not included if transaction source is url', () => {
// eslint-disable-next-line deprecation/deprecation
const transaction = new Transaction({
name: 'tx',
metadata: {
Expand All @@ -106,6 +109,7 @@ describe('getDynamicSamplingContextFromSpan', () => {
['is included if transaction source is parameterized route/url', 'route'],
['is included if transaction source is a custom name', 'custom'],
])('%s', (_: string, source) => {
// eslint-disable-next-line deprecation/deprecation
const transaction = new Transaction({
name: 'tx',
metadata: {
Expand Down