Skip to content

feat(core): Deprecate methods on Hub #10124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2024
Merged

feat(core): Deprecate methods on Hub #10124

merged 1 commit into from
Jan 10, 2024

Conversation

@mydea
Copy link
Member

@mydea mydea commented Jan 10, 2024

Except for bindClient() which needs a separate replacement. For everything else we already have a replacement in place!

Then in a follow up we can deprecate getCurrentHub() itself.

@mydea mydea requested review from AbhiPrasad, Lms24 and lforst January 10, 2024 08:56
@mydea mydea self-assigned this Jan 10, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 76.97 KB (+0.12% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.35 KB (+0.15% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 61.98 KB (+0.18% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.37 KB (+0.28% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.97 KB (+0.76% 🔺)
@sentry/browser - Webpack (gzipped) 22.3 KB (+0.9% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 74.61 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.24 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.07 KB (+0.13% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.89 KB (+0.63% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 208.63 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 96.69 KB (-0.06% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 71.29 KB (+0.48% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.04 KB (+0.11% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.71 KB (+0.12% 🔺)
@sentry/react - Webpack (gzipped) 22.34 KB (+0.94% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.37 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.49 KB (+0.02% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 16.99 KB (+1.45% 🔺)

@mydea mydea force-pushed the fn/deprecate-hubMethods branch from 59d1061 to 661cd22 Compare January 10, 2024 09:13
lforst
lforst approved these changes Jan 10, 2024
View reviewed changes
@mydea mydea force-pushed the fn/deprecate-hubMethods branch from 661cd22 to 039bad6 Compare January 10, 2024 11:09
@mydea
feat(core): Deprecate methods on Hub
983624e 
Except for `bindClient()` which needs a separate replacement. For everything else we already have a replacement in place!
@mydea mydea force-pushed the fn/deprecate-hubMethods branch from 039bad6 to 983624e Compare January 10, 2024 12:33
@mydea mydea merged commit ac278e7 into develop Jan 10, 2024
@mydea mydea deleted the fn/deprecate-hubMethods branch January 10, 2024 16:43
c298lee pushed a commit that referenced this pull request Jan 10, 2024
@mydea @c298lee
feat(core): Deprecate methods on Hub (#10124)
3dfbd06 
Except for `bindClient()` which needs a separate replacement. For
everything else we already have a replacement in place!

Then in a follow up we can deprecate `getCurrentHub()` itself.
c298lee pushed a commit that referenced this pull request Jan 10, 2024
@mydea @c298lee
feat(core): Deprecate methods on Hub (#10124)
7e2e415 
Except for `bindClient()` which needs a separate replacement. For
everything else we already have a replacement in place!

Then in a follow up we can deprecate `getCurrentHub()` itself.
billyvg pushed a commit that referenced this pull request Jan 10, 2024
@mydea @billyvg
feat(core): Deprecate methods on Hub (#10124)
09bd959 
Except for `bindClient()` which needs a separate replacement. For
everything else we already have a replacement in place!

Then in a follow up we can deprecate `getCurrentHub()` itself.
c298lee pushed a commit that referenced this pull request Jan 10, 2024
@mydea @c298lee
feat(core): Deprecate methods on Hub (#10124)
a521ffc 
Except for `bindClient()` which needs a separate replacement. For
everything else we already have a replacement in place!

Then in a follow up we can deprecate `getCurrentHub()` itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

+1 more reviewer

@lforst lforst lforst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mydea @lforst @Lms24