Skip to content

test(node): Add memory leak test for LocalVariables #10080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2024
Merged

test(node): Add memory leak test for LocalVariables #10080

merged 1 commit into from
Jan 8, 2024

Conversation

@timfish
Copy link
Collaborator

@timfish timfish commented Jan 5, 2024 •
edited
Loading

This PR adds a test for the LocalVariable integration that causes 20k caught exceptions and checks that the memory usage does not go over 100MB.

@timfish timfish marked this pull request as ready for review January 5, 2024 19:47
@timfish timfish requested a review from lforst January 5, 2024 19:48
lforst
lforst approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you! I am wondering. If we try this change on the pre-#10077 SDK, will this test fail?

@AbhiPrasad AbhiPrasad merged commit 3160419 into getsentry:develop Jan 8, 2024
@timfish
Copy link
Collaborator Author

timfish commented Jan 8, 2024

If we try this change on the pre-#10077 SDK, will this test fail?

I will check!

@timfish timfish deleted the feat/local-variables-memory-leak branch January 8, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

+1 more reviewer

@lforst lforst lforst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timfish @lforst @AbhiPrasad