Skip to content

fix(node): Revert to only use sync debugger for LocalVariables #10077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2024
Merged

fix(node): Revert to only use sync debugger for LocalVariables #10077

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4efdc8c
fix(node): Revert to only use sync debugger for `LocalVariables`
timfish Jan 5, 2024
9d30e0c
Fix linting
timfish Jan 5, 2024
7586d18
Merge branch 'develop' into fix/node-local-variables
timfish Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions packages/node/src/integrations/local-variables/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,6 @@
import { convertIntegrationFnToClass } from '@sentry/core';
import type { IntegrationFn } from '@sentry/types';
import { NODE_VERSION } from '../../nodeVersion';
import type { Options } from './common';
import { localVariablesAsync } from './local-variables-async';
import { localVariablesSync } from './local-variables-sync';

const INTEGRATION_NAME = 'LocalVariables';

/**
* Adds local variables to exception frames
*/
const localVariables: IntegrationFn = (options: Options = {}) => {
return NODE_VERSION.major < 19 ? localVariablesSync(options) : localVariablesAsync(options);
};
import { LocalVariablesSync } from './local-variables-sync';

/**
* Adds local variables to exception frames
*/
// eslint-disable-next-line deprecation/deprecation
export const LocalVariables = convertIntegrationFnToClass(INTEGRATION_NAME, localVariables);
export const LocalVariables = LocalVariablesSync;