feat(core): Deprecate startTransaction()
#10073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Jan 5, 2024
mydea
force-pushed
the
fn/deprecate-startTransaction
branch
from
f795461 to
6cb3c2b
Compare
Lms24
approved these changes
Jan 5, 2024
Comment on lines
+159
to
+162
| return parentSpan | ||
| ? parentSpan.startChild(ctx) | ||
| : // eslint-disable-next-line deprecation/deprecation | ||
| hub.startTransaction(ctx); |
There was a problem hiding this comment.
not relevant for this PR but this makes me realize we'll probably need to create an internal startTxn utility for us as a replacement of hub.startTransaction when its removed as long as we're still sending spans in transacitons.
There was a problem hiding this comment.
jup, also had that thought - for now we'll still need some internal thing, but we can refactor this on the v8 branch then I'd say :)
Co-authored-by: Lukas Stracke <[email protected]>
c298lee
pushed a commit
that referenced
this pull request
Jan 9, 2024
This finally deprecates `startTransaction()`. There are only few remaining usages in our own code base, which we can refactor as we go. I chose to leave usages in E2E/integration tests for now, we can then refactor them when we get rid of these to ensure the behavior remains the same. --------- Co-authored-by: Lukas Stracke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally deprecates
startTransaction(). There are only few remaining usages in our own code base, which we can refactor as we go.I chose to leave usages in E2E/integration tests for now, we can then refactor them when we get rid of these to ensure the behavior remains the same.