Unhandled exception handler can potentially crash

[rchl]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/vue

SDK Version

7.80.0

Framework Version

Vue 2

Link to Sentry event

No response

SDK Setup

No response

Steps to Reproduce

I am the maintainer of @nuxtjs/sentry and I have this code in the module:

https://github.com/nuxt-community/sentry-module/blob/e728a349e212cb422a385ee8619cf00353b318fd/src/templates/plugin.lazy.js#L21-L21

It duplicates the code that Sentry SDK has in:

sentry-javascript/packages/browser/src/loader.js

Line 205 in 9428c9a

p: 'reason' in e ? e.reason : 'detail' in e && 'reason' in e.detail ? e.detail.reason : e

Recently I've noticed that my code causes crashes like e.detail is not an Object. (evaluating '"reason"in e.detail') so then I would assume that Sentry's SDK can also crash in the same way. So while I will fix it on my side, the SDK should also do so.

The 'reason' in e ? e.reason : 'detail' in e && 'reason' in e.detail ? e.detail.reason : e can crash because 'reason' in e.detail will crash if e.detail is undefined and there is no truthiness check done against it first.

Expected Result

no crash

Actual Result

crash

[mydea]

Thank you for bringing this up! You are right, this should be guarded better. That's actually not in the SDK but in the loader script (this is just included in the SDK for tests), I will fix this 🙏

[mydea]

Thanks again for bringing this up, I've updated this in the loader script and added a test for this, actually :)