SDK not deduplicating events

[bruno-garcia]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using? If you use the CDN bundles, please specify the exact bundle (e.g. bundle.tracing.min.js) in your SDK setup.

@sentry/react

SDK Version

7.36.0

Framework Version

No response

Link to Sentry event

https://sentry.sentry.io/issues/3924078024/events/0c790cbbb1474559b3d4c0e4e0971e5a/?project=11276&referrer=previous-event

SDK Setup

It's happening in Sentry.

Dedup is a default integration.

Note that Sentry only compares stack traces and fingerprints.

The event seems to have the exact same stack trace.

Steps to Reproduce

Example: https://sentry.sentry.io/issues/3924078024/events/0c790cbbb1474559b3d4c0e4e0971e5a/?project=11276&referrer=previous-event

Expected Result

1 event per user for this specific error.

Actual Result

445 events for a single user in the same hour

SecurityError: Sandbox access violation: Blocked a frame at "https://redacted" from accessing a cross-origin frame. The frame being accessed is sandboxed and lacks the "allow-same-origin" flag.

SecurityError: Sandbox access violation: Blocked a frame at "https://redacted.sentry.io" from accessing a cross-origin frame.  The frame being accessed is sandboxed and lacks the "allow-same-origin" flag.
  at ? (/_static/dist/sentry/chunks/vendors-node_modules_emotion_is-prop-valid_node_modules_emotion_memoize_dist_memoize_browser_-ff7b0a.684367a151ee06f5f456.js:2:104820)
  at forEach([native code])
  at ? (/_static/dist/sentry/chunks/vendors-node_modules_emotion_is-prop-valid_node_modules_emotion_memoize_dist_memoize_browser_-ff7b0a.684367a151ee06f5f456.js:2:104865)
  at ? (/_static/dist/sentry/chunks/vendors-node_modules_emotion_is-prop-valid_node_modules_emotion_memoize_dist_memoize_browser_-ff7b0a.684367a151ee06f5f456.js:2:105253)
  at forEach([native code])
  at ? (/_static/dist/sentry/chunks/vendors-node_modules_emotion_is-prop-valid_node_modules_emotion_memoize_dist_memoize_browser_-ff7b0a.684367a151ee06f5f456.js:2:122154)
  at stopRecording(/_static/dist/sentry/chunks/vendors-node_modules_emotion_is-prop-valid_node_modules_emotion_memoize_dist_memoize_browser_-ff7b0a.684367a151ee06f5f456.js:2:184255)
  at ? (/_static/dist/sentry/chunks/vendors-node_modules_emotion_is-prop-valid_node_modules_emotion_memoize_dist_memoize_browser_-ff7b0a.684367a151ee06f5f456.js:2:130744)
  at asyncFunctionResume([native code])
  at ? ([native code])
  at promiseReactionJobWithoutPromise([native code])
  at promiseReactionJob([native code])

Seems in this release we failed to upload sourcemaps

[mydea]

Hmm, maybe this is because the dedupe integration really only looks at the previous event.
So if a different event is captured in between, it will capture this again, think:

• SecurityError: Sandbox access violation...
• Transaction
• SecurityError: Sandbox access violation...
• Transaction
• SecurityError: Sandbox access violation...

Would capture each of the security errors. One thought was this may be related to replays, but then this should also not trigger that many events in between these errors.

Looking at the code, if the stacktrace & the fingerprint match (which they seem to do in this case), the only scenario I can see where this is still captures is that it isn't properly comparing it with the "correct" previous event. Then again, this was a lot of errors in a very short amount of time, so not even sure if this would explain these being captured 🤔

[mydea]

Possibly, this #7172 may fix this, but TBH I am not sure if this is the root problem here - it may, it may not 🤔 But it's def. a fix in the right direction!

[mydea]

We shipped an update for the dedupe integration, how can we verify that this fixed the problem? 🤔

[github-actions]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[bruno-garcia]

We having seeing this issue since so closing. Thanks @mydea