Small issues with the replay

[futzlarson]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/angular
Again not actually angular, using loader for errors and https://browser.sentry-cdn.com/7.36.0/bundle.tracing.replay.min.js for replays, but those aren't options in the form.

SDK Version

7.36.0

Framework Version

No response

Link to Sentry event

https://auxbus.sentry.io/replays/javascript:cd5072956c504a8390e6aa09b979a441/?project=1375267&query=duration%3A%3E%3D5&referrer=%2Freplays%2F&statsPeriod=14d&yAxis=count%28%29

SDK Setup

            Sentry.init({
                dsn: 'https://435a8c34ae0641a5ae9d3da6d7d9afa7@o224628.ingest.sentry.io/1375267',
                environment: '{{ App::environment() }}',
                replaysSessionSampleRate: {{ prod() ? '0.1' : '1.0' }},
                replaysOnErrorSampleRate: 1.0,
                integrations: [
                    new Sentry.Integrations.Replay({
                        maskAllText: false,
                        blockAllMedia: false
                    })
                ]
            });

Steps to Reproduce

If you watched the replay referenced, I noticed a few things:

1. Fullscreen isn't actually fullscreen - how come that is cropped? There could be useful context cut out. Could it be from dev tools being open?
2. Despite maskAllText being false, there are some asterisks (which were not in the textarea) along with the text. Then a few seconds in, it turns to all asterisks and continues while typing. Shouldn't that display the user's (my) text? See first seven seconds of video.
3. Despite blockAllMedia being false, the FontAwesome icons are also stripped out. I suspect maybe all images are?

That said, this is exciting and I'm really glad you added this feature.

Expected Result

1. Fullscreen displays the entire window
2. maskAllText=false should display user entry
3. blockAllMedia=false shouldn't block images or glyphs

Actual Result

None of these are true.

[futzlarson]

Couple more things.

If you watch this video, around 5:12 the url definitely changes (it's not a SPA) but at a glance I don't see that anywhere, nor does the url above the video change.

Also what does LCP mean?

[billyvg]

Fullscreen isn't actually fullscreen - how come that is cropped? There could be useful context cut out. Could it be from dev tools being open?

Hmm my guess is that it is indeed dev tools, does this happen for all replays?

Despite maskAllText being false, there are some asterisks (which were not in the textarea) along with the text. Then a few seconds in, it turns to all asterisks and continues while typing. Shouldn't that display the user's (my) text? See first seven seconds of video.

This is half intended and half a bug... maskAllInputs is causing it to be masked, you should not be seeing text in the text area at all, will look into that.

Despite blockAllMedia being false, the FontAwesome icons are also stripped out. I suspect maybe all images are?

It's trying to load fonts from your test domain which I'm guessing is local?

If you watch this video, around 5:12 the url definitely changes (it's not a SPA) but at a glance I don't see that anywhere, nor does the url above the video change.

yeah this looks like a bug

Also what does LCP mean?

https://web.dev/lcp/

[futzlarson]

Hmm my guess is that it is indeed dev tools, does this happen for all replays?

Nope. I think you can ignore this.

This is half intended and half a bug... maskAllInputs is causing it to be masked, you should not be seeing text in the text area at all, will look into that.

I'm not using maskAllInputs, I'm using maskAllText, which is false. So the text shouldn't be masked?

It's trying to load fonts from your test domain which I'm guessing is local?

No that's a public staging server.

[billyvg]

I'm not using maskAllInputs, I'm using maskAllText, which is false. So the text shouldn't be masked?

maskAllInputs defaults to true and is a separate setting from maskAllText

[futzlarson]

FWIW, I was not aware of that setting, nor that it was true by default.

[bruno-garcia]

FWIW, I was not aware of that setting, nor that it was true by default.

Curious what route did you take to install the Replay integration?
Currently, if you go through the Replay menu on the left, it doesn't mention this option (so you have its default value)

But if you read the docs, we do point out the options already on the Set Up snippet. With true explicitly. The lack of defining the value takes the same effect (since true is default),

https://docs.sentry.io/platforms/javascript/session-replay/#set-up

All privacy settings are documented here though, with their default value next to them: https://docs.sentry.io/platforms/javascript/session-replay/privacy/

[futzlarson]

Curious what route did you take to install the Replay integration?

CDN + this page, which does not mention maskAllInputs.

Currently, if you go through the Replay menu on the left

FWIW, I don't know how to access this anymore once it's been set up.

---

Still wondering about these:

I'm using maskAllText, which is false. So the text shouldn't be masked?

Despite blockAllMedia being false, the FontAwesome icons are also stripped out (from a public staging server). I suspect maybe all images are?

[billyvg]

I'm using maskAllText, which is false. So the text shouldn't be masked?

Text outside of inputs won't be masked but you'll have to set maskAllInputs as false if you want those unmasked as well. I have a ticket for a separate bug related to these two options here: #7072

Despite blockAllMedia being false, the FontAwesome icons are also stripped out (from a public staging server). I suspect maybe all images are?

Further on in the replay you'll see that images are loaded. The fonts aren't being loaded due to CORS. You'll need to add sentry.io as a valid origin on your fonts server. We have a ticket to improve this experience here: #7007