Exception "Locale 'fullwide' is not well-formed" under Internet Explorer 11

[pelov]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/vue

SDK Version

7.7.0

Framework Version

7.7.0

Link to Sentry event

No response

Steps to Reproduce

When running under Internet Explorer 11 we get an exception "Locale 'fullwide' is not well-formed". This could be easily reproduced without even running any application by simply typing in the IE 11 console

rate = 1
rate.toLocaleString('fullwide', {useGrouping: false, maximumFractionDigits: 16})

Sentry was still working with IE11 until version 7.2.0. Looks like this particular problem was introduced in version 7.3.0 by #5292 and now in the latest version 7.7.0 the code has moved to packages/tracing/src/transaction.ts.

Expected Result

Sentry to work under IE11.

Actual Result

Exception "Locale 'fullwide' is not well-formed".

[Lms24]

Hi @pelov and thanks for writing in. Interesting, I thought that IE11 supported Number.toLocaleString (with an exception about rounding but nothing about the fullwide locale. Also, according to MDN, locales should be supported with IE11.

Can't promise we'll look a this immediately but I'll backlog this for sure. We might not need the special number formatting atfter all but we still need to sync with other teams on that. Is there a way you could polyfill or workaround this for the time being (since we're es6 by default as of v7, I assume you're downcompiling and adding polyfills)?

[pelov]

IE11 supports Number.toLocaleString but doesn't support the fullwide locale.

We use babel to compile our code. I'll see if I can find some polyfill that will work.

[AbhiPrasad]

IMO let's avoid having the special number formatting. As such, let's remove the fullwide local if we can.

[Lms24]

let's avoid having the special number formatting

Since we decided at TSC that Relay will accept JSON format for the sample rate, I think we can do this. Just need to check back if this is already implemented. But overall, I agree that's the best course of action here and it should also save us some bytes.