`beforeSend` is being ignored when `disablePerformance` is `false` (default)

[netes]

• Review the documentation: https://docs.sentry.io/
• Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
• Use the latest release: https://github.com/getsentry/sentry-javascript/releases
• Provide a link to the affected event from your Sentry account

Package + Version

• @sentry/browser
• @sentry/ember
• @sentry/node
• raven-js
• raven-node (raven for node)
• other:

Version:

6.4.0

Description

We wanted to turn on performance metrics for our project in Sentry as it looked like a pretty neat feature, but... Project is written in Ember, we're using @sentry/ember and up until now everything worked correctly. After turning on performance metrics (previously we were using disablePerformance: true; option) our hooks stopped working. We're using beforeSend pretty extensively, like this:

  InitSentryForEmber({
    beforeSend(event, hint) {
      ...
    },
  });

I noticed that if performance metrics are on (or rather disablePerformance is not set), beforeSend hook never fires. I checked it a few times by disabling and enabling metrics, but always with the same result. Looks like enabling performance metrics somehow overrides our settings?

[netes]

I took a short look at the code and it looks like it takes only the configuration that lives in environment.js when performance instrumentation is turned on. It ignores what is passed to InitSentryForEmber. Is it intentional?

[k-fish]

@netes hey 👋 , thanks for letting us know.

Passing config to initSentryForEmber was initially an override for testing and we recommended all configuration to be put in config/environment.js. But since functions can't be serialized in the environment config files, I imagine moving forward we'll likely recommend all the usual Sentry options be passed to InitSentryForEmber and leave addon-specific options for the environment config.

For now I'm putting up a fix that should allow options like the beforeSend you added to work when passed into InitSentryForEmber. Hopefully that will fix it for you.

[netes]

For now I'm putting up a fix that should allow options like the beforeSend you added to work when passed into InitSentryForEmber. Hopefully that will fix it for you.

Great to hear that! Thanks!

[AbhiPrasad]

We've merged in #3563, which should be available with the Ember SDK v6.4.1.

Thanks again for reporting!

[netes]

I'm not sure what's the problem here, but it seems that it works fine on development environment, but does not on production. On production it never stops in beforeSend hook 🤔 The version is of course the same (6.4.1), so I'm not sure what might be the cause. Any ideas?