ref: PR feedback

Author: mydea

packages/types/src/event.ts

@@ -61,8 +61,12 @@ export interface Event {
 /** JSDoc */
 export type EventType = 'transaction' | 'profile';
 
-export type ErrorEvent = Event & { type: undefined };
-export type TransactionEvent = Event & { type: 'transaction' };
+export interface ErrorEvent extends Event {
+  type: undefined;
+}
+export interface TransactionEvent extends Event {
+  type: 'transaction';
+}
 
 /** JSDoc */
 export interface EventHint {

packages/types/src/options.ts

@@ -222,30 +222,28 @@ export interface ClientOptions<TO extends BaseTransportOptions = BaseTransportOp
    */
   tracesSampler?: (samplingContext: SamplingContext) => number | boolean;
 
+  // TODO v8: Narrow the response type to `ErrorEvent` - this is technically a breaking change.
   /**
    * An event-processing callback for error and message events, guaranteed to be invoked after all other event
    * processors, which allows an event to be modified or dropped.
    *
    * Note that you must return a valid event from this callback. If you do not wish to modify the event, simply return
    * it at the end. Returning `null` will cause the event to be dropped.
    *
-   * TODO v8: Narrow the response type to `ErrorEvent` - this is technically a breaking change.
-   *
    * @param event The error or message event generated by the SDK.
    * @param hint Event metadata useful for processing.
    * @returns A new event that will be sent | null.
    */
   beforeSend?: (event: ErrorEvent, hint: EventHint) => PromiseLike<Event | null> | Event | null;
 
+  // TODO v8: Narrow the response type to `TransactionEvent` - this is technically a breaking change.
   /**
    * An event-processing callback for transaction events, guaranteed to be invoked after all other event
    * processors. This allows an event to be modified or dropped before it's sent.
    *
    * Note that you must return a valid event from this callback. If you do not wish to modify the event, simply return
    * it at the end. Returning `null` will cause the event to be dropped.
    *
-   * TODO v8: Narrow the response type to `TransactionEvent` - this is technically a breaking change.
-   *
    * @param event The error or message event generated by the SDK.
    * @param hint Event metadata useful for processing.
    * @returns A new event that will be sent | null.