ref: PR feedback

Author: mydea

packages/core/src/baseclient.ts

@@ -806,19 +806,19 @@ function _validateBeforeSendResult(
 /**
  * Process the matching `beforeSendXXX` callback.
  */
-function processBeforeSend<T extends Event>(
+function processBeforeSend(
   options: ClientOptions,
-  event: T,
+  event: Event,
   hint: EventHint,
-): PromiseLike<T | null> | T | null {
+): PromiseLike<Event | null> | Event | null {
   const { beforeSend, beforeSendTransaction } = options;
 
   if (isErrorEvent(event) && beforeSend) {
-    return beforeSend(event, hint) as PromiseLike<T | null> | T | null;
+    return beforeSend(event, hint);
   }
 
   if (isTransactionEvent(event) && beforeSendTransaction) {
-    return beforeSendTransaction(event, hint) as PromiseLike<T | null> | T | null;
+    return beforeSendTransaction(event, hint);
   }
 
   return event;

packages/types/src/options.ts

@@ -229,6 +229,8 @@ export interface ClientOptions<TO extends BaseTransportOptions = BaseTransportOp
    * Note that you must return a valid event from this callback. If you do not wish to modify the event, simply return
    * it at the end. Returning `null` will cause the event to be dropped.
    *
+   * TODO v8: Narrow the response type to `ErrorEvent` - this is technically a breaking change.
+   *
    * @param event The error or message event generated by the SDK.
    * @param hint Event metadata useful for processing.
    * @returns A new event that will be sent | null.
@@ -242,6 +244,8 @@ export interface ClientOptions<TO extends BaseTransportOptions = BaseTransportOp
    * Note that you must return a valid event from this callback. If you do not wish to modify the event, simply return
    * it at the end. Returning `null` will cause the event to be dropped.
    *
+   * TODO v8: Narrow the response type to `TransactionEvent` - this is technically a breaking change.
+   *
    * @param event The error or message event generated by the SDK.
    * @param hint Event metadata useful for processing.
    * @returns A new event that will be sent | null.