ref: Drop no-plusplus rule & refactor to use ++ / -- (#6327)

Author: mydea

packages/browser/src/helpers.ts

@@ -25,9 +25,9 @@ export function shouldIgnoreOnError(): boolean {
  */
 export function ignoreNextOnError(): void {
   // onerror should trigger before setTimeout
-  ignoreOnError += 1;
+  ignoreOnError++;
   setTimeout(() => {
-    ignoreOnError -= 1;
+    ignoreOnError--;
   });
 }
 

packages/browser/test/integration/polyfills/promise.js

@@ -102,7 +102,6 @@
     observer.observe(node, { characterData: true });
 
     return function () {
-      // eslint-disable-next-line no-plusplus
       node.data = iterations = ++iterations % 2;
     };
   }
@@ -468,11 +467,11 @@
 
   var id = 0;
   function nextId() {
-    return (id += 1);
+    return ++id;
   }
 
   function makePromise(promise) {
-    promise[PROMISE_ID] = id += 1;
+    promise[PROMISE_ID] = ++id;
     promise._state = undefined;
     promise._result = undefined;
     promise._subscribers = [];
@@ -535,7 +534,7 @@
         if (_then === then && entry._state !== PENDING) {
           this._settledAt(entry._state, i, entry._result);
         } else if (typeof _then !== 'function') {
-          this._remaining -= 1;
+          this._remaining--;
           this._result[i] = entry;
         } else if (c === Promise$2) {
           var promise = new c(noop);
@@ -562,7 +561,7 @@
       var promise = this.promise;
 
       if (promise._state === PENDING) {
-        this._remaining -= 1;
+        this._remaining--;
 
         if (state === REJECTED) {
           reject(promise, value);

packages/core/src/baseclient.ts

@@ -714,14 +714,14 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
    * Occupies the client with processing and event
    */
   protected _process<T>(promise: PromiseLike<T>): void {
-    this._numProcessing += 1;
+    this._numProcessing++;
     void promise.then(
       value => {
-        this._numProcessing -= 1;
+        this._numProcessing--;
         return value;
       },
       reason => {
-        this._numProcessing -= 1;
+        this._numProcessing--;
         return reason;
       },
     );

packages/core/test/mocks/transport.ts

@@ -18,10 +18,10 @@ export function makeFakeTransport(delay: number = 2000): {
   let sentCount = 0;
   const makeTransport = () =>
     createTransport({ recordDroppedEvent: () => undefined, textEncoder: new TextEncoder() }, () => {
-      sendCalled += 1;
+      sendCalled++;
       return new SyncPromise(async res => {
         await sleep(delay);
-        sentCount += 1;
+        sentCount++;
         res({});
       });
     });

packages/eslint-config-sdk/src/index.js

@@ -196,9 +196,6 @@ module.exports = {
   ],
 
   rules: {
-    // We want to prevent usage of unary operators outside of for loops
-    'no-plusplus': ['error', { allowForLoopAfterthoughts: true }],
-
     // Disallow usage of console and alert
     'no-console': 'error',
     'no-alert': 'error',

packages/gatsby/test/integration.test.tsx

@@ -22,7 +22,7 @@ describe('useEffect', () => {
     onClientEntry(undefined, {
       beforeSend: (event: any) => {
         expect(event).not.toBeUndefined();
-        calls += 1;
+        calls++;
 
         return null;
       },

packages/integration-tests/utils/helpers.ts

@@ -69,7 +69,7 @@ async function getMultipleRequests(
     function requestHandler(request: Request): void {
       if (urlRgx.test(request.url())) {
         try {
-          reqCount -= 1;
+          reqCount--;
           requestData.push(requestParser(request));
 
           if (reqCount === 0) {

packages/integration-tests/utils/web-vitals/cls.ts

@@ -25,7 +25,7 @@ async function moveBy(elem: HTMLParagraphElement, percent: number): Promise<void
   if (elem.getAttribute('id') === 'partial') {
     const max = Number(elem.getAttribute('max-steps'));
     let current = Number(elem.getAttribute('steps'));
-    current += 1;
+    current++;
     if (current > max) {
       return;
     }
@@ -52,7 +52,7 @@ function howMany(desiredCls: number): { extraSteps: number; createParagraphs: nu
   const extraSteps = Math.round((desiredCls - fullRuns * 0.095) / 0.005);
   let create = fullRuns;
   if (extraSteps > 0) {
-    create += 1;
+    create++;
   }
 
   return { extraSteps: extraSteps, createParagraphs: create };

packages/node/src/integrations/http.ts

@@ -247,7 +247,7 @@ function _createWrappedRequestMethodFactory(
 
           const transaction = parentSpan.transaction;
           if (transaction) {
-            transaction.metadata.propagations += 1;
+            transaction.metadata.propagations++;
           }
         }
       }

packages/replay/.eslintrc.js

@@ -65,8 +65,6 @@ module.exports = {
         '@typescript-eslint/no-floating-promises': 'off',
         // TODO (medium-prio): Re-enable this after migration
         'jsdoc/require-jsdoc': 'off',
-        // TODO: Do we even want to turn this on? Why not enable ++?
-        'no-plusplus': 'off',
       },
     },
     {