Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Nov 29, 2022

This PR removes the no-plusplus eslint rule, as it doesn't really apply to us. By replacing usage of a += 1 with a++, and a -= 1 with a-- we should actually be able to shave a few bytes off our bundles.

@mydea mydea requested a review from a team November 29, 2022 11:22
@mydea mydea self-assigned this Nov 29, 2022
@mydea mydea requested review from AbhiPrasad and lobsterkatie and removed request for a team November 29, 2022 11:22
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.53 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.42 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.21 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.76 KB (-0.02% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.94 KB (+0.01% 🔺)
@sentry/browser - Webpack (minified) 65.25 KB (-0.02% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.96 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.96 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.41 KB (-0.03% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.83 KB (-0.01% 🔽)
@sentry/replay index.js 83.65 KB (-0.07% 🔽)
@sentry/replay - Webpack (gzipped + minified) 83.67 KB (-0.07% 🔽)
@sentry/replay - Webpack (minified) 272.53 KB (-0.06% 🔽)

@mydea mydea merged commit c6f9dfe into master Nov 29, 2022
@mydea mydea deleted the fn/drop-no-plusplus-rule branch November 29, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants