rename to AddEventResult

Author: billyvg

packages/replay/src/eventBuffer.ts

@@ -4,7 +4,7 @@
 import { captureException } from '@sentry/core';
 import { logger } from '@sentry/utils';
 
-import type { EventBuffer, RecordingEvent, WorkerAddEventResponse, WorkerRequest } from './types';
+import type { AddEventResult, EventBuffer, RecordingEvent, WorkerRequest } from './types';
 import workerString from './worker/worker.js';
 
 interface CreateEventBufferParams {
@@ -53,7 +53,7 @@ class EventBufferArray implements EventBuffer {
     this._events = [];
   }
 
-  public async addEvent(event: RecordingEvent, isCheckout?: boolean): Promise<void> {
+  public async addEvent(event: RecordingEvent, isCheckout?: boolean): Promise<AddEventResult> {
     if (isCheckout) {
       this._events = [event];
       return;
@@ -110,7 +110,7 @@ export class EventBufferCompressionWorker implements EventBuffer {
    *
    * Returns true if event was successfuly received and processed by worker.
    */
-  public async addEvent(event: RecordingEvent, isCheckout?: boolean): Promise<WorkerAddEventResponse> {
+  public async addEvent(event: RecordingEvent, isCheckout?: boolean): Promise<AddEventResult> {
     if (isCheckout) {
       // This event is a checkout, make sure worker buffer is cleared before
       // proceeding.
@@ -180,7 +180,7 @@ export class EventBufferCompressionWorker implements EventBuffer {
   /**
    * Send the event to the worker.
    */
-  private async _sendEventToWorker(event: RecordingEvent): Promise<WorkerAddEventResponse> {
+  private async _sendEventToWorker(event: RecordingEvent): Promise<AddEventResult> {
     const promise = this._postMessage<void>({
       id: this._getAndIncrementId(),
       method: 'addEvent',

packages/replay/src/replay.ts

@@ -34,7 +34,7 @@ import type {
   ReplayPluginOptions,
   SendReplay,
   Session,
-  WorkerAddEventResponse,
+  AddEventResult,
 } from './types';
 import { addEvent } from './util/addEvent';
 import { addMemoryEntry } from './util/addMemoryEntry';
@@ -692,7 +692,7 @@ export class ReplayContainer implements ReplayContainerInterface {
    * Observed performance events are added to `this.performanceEvents`. These
    * are included in the replay event before it is finished and sent to Sentry.
    */
-  addPerformanceEntries(): Promise<Array<WorkerAddEventResponse | null>> {
+  addPerformanceEntries(): Promise<Array<AddEventResult | null>> {
     // Copy and reset entries before processing
     const entries = [...this.performanceEvents];
     this.performanceEvents = [];

packages/replay/src/types.ts

@@ -51,7 +51,7 @@ export interface WorkerResponse {
   response: unknown;
 }
 
-export type WorkerAddEventResponse = void;
+export type AddEventResult = void;
 
 export interface SampleRates {
   /**
@@ -223,7 +223,7 @@ export interface EventBuffer {
    *
    * Returns true if event was successfully added.
    */
-  addEvent(event: RecordingEvent, isCheckout?: boolean): Promise<WorkerAddEventResponse>;
+  addEvent(event: RecordingEvent, isCheckout?: boolean): Promise<AddEventResult>;
 
   /**
    * Clears and returns the contents and the buffer.

packages/replay/src/util/addEvent.ts

@@ -1,5 +1,5 @@
 import { SESSION_IDLE_DURATION } from '../constants';
-import type { RecordingEvent, ReplayContainer, WorkerAddEventResponse } from '../types';
+import type { AddEventResult,RecordingEvent, ReplayContainer } from '../types';
 
 /**
  * Add an event to the event buffer
@@ -8,7 +8,7 @@ export async function addEvent(
   replay: ReplayContainer,
   event: RecordingEvent,
   isCheckout?: boolean,
-): Promise<WorkerAddEventResponse | null> {
+): Promise<AddEventResult | null> {
   if (!replay.eventBuffer) {
     // This implies that `_isEnabled` is false
     return null;

packages/replay/src/util/addMemoryEntry.ts

@@ -1,5 +1,5 @@
 import { WINDOW } from '../constants';
-import type { ReplayContainer, ReplayPerformanceEntry, WorkerAddEventResponse } from '../types';
+import type { AddEventResult, ReplayContainer, ReplayPerformanceEntry } from '../types';
 import { createPerformanceSpans } from './createPerformanceSpans';
 
 type ReplayMemoryEntry = ReplayPerformanceEntry & { data: { memory: MemoryInfo } };
@@ -14,7 +14,7 @@ interface MemoryInfo {
  * Create a "span" for the total amount of memory being used by JS objects
  * (including v8 internal objects).
  */
-export async function addMemoryEntry(replay: ReplayContainer): Promise<Array<WorkerAddEventResponse | null>> {
+export async function addMemoryEntry(replay: ReplayContainer): Promise<Array<AddEventResult | null>> {
   // window.performance.memory is a non-standard API and doesn't work on all browsers, so we try-catch this
   try {
     return Promise.all(

packages/replay/src/util/createPerformanceSpans.ts

@@ -1,6 +1,6 @@
 import { EventType } from 'rrweb';
 
-import type { ReplayContainer, ReplayPerformanceEntry, WorkerAddEventResponse } from '../types';
+import type { AddEventResult,ReplayContainer, ReplayPerformanceEntry } from '../types';
 import { addEvent } from './addEvent';
 
 /**
@@ -9,7 +9,7 @@ import { addEvent } from './addEvent';
 export function createPerformanceSpans(
   replay: ReplayContainer,
   entries: ReplayPerformanceEntry[],
-): Promise<WorkerAddEventResponse | null>[] {
+): Promise<AddEventResult | null>[] {
   return entries.map(({ type, start, end, name, data }) =>
     addEvent(replay, {
       type: EventType.Custom,