void

Author: billyvg

packages/replay/src/eventBuffer.ts

@@ -4,7 +4,7 @@
 import { captureException } from '@sentry/core';
 import { logger } from '@sentry/utils';
 
-import type { EventBuffer, RecordingEvent, WorkerAddEventResponse, WorkerRequest, WorkerResponse } from './types';
+import type { EventBuffer, RecordingEvent, WorkerAddEventResponse, WorkerRequest } from './types';
 import workerString from './worker/worker.js';
 
 interface CreateEventBufferParams {
@@ -53,14 +53,14 @@ class EventBufferArray implements EventBuffer {
     this._events = [];
   }
 
-  public async addEvent(event: RecordingEvent, isCheckout?: boolean): Promise<boolean> {
+  public async addEvent(event: RecordingEvent, isCheckout?: boolean): Promise<void> {
     if (isCheckout) {
       this._events = [event];
-      return true;
+      return;
     }
 
     this._events.push(event);
-    return true;
+    return;
   }
 
   public finish(): Promise<string> {
@@ -134,7 +134,7 @@ export class EventBufferCompressionWorker implements EventBuffer {
   /**
    * Post message to worker and wait for response before resolving promise.
    */
-  private _postMessage({ id, method, args }: WorkerRequest): Promise<WorkerResponse['response']> {
+  private _postMessage<T>({ id, method, args }: WorkerRequest): Promise<T> {
     return new Promise((resolve, reject) => {
       // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
       const listener = ({ data }: MessageEvent) => {
@@ -181,7 +181,7 @@ export class EventBufferCompressionWorker implements EventBuffer {
    * Send the event to the worker.
    */
   private async _sendEventToWorker(event: RecordingEvent): Promise<WorkerAddEventResponse> {
-    const promise = this._postMessage({
+    const promise = this._postMessage<void>({
       id: this._getAndIncrementId(),
       method: 'addEvent',
       args: [event],
@@ -190,19 +190,19 @@ export class EventBufferCompressionWorker implements EventBuffer {
     // XXX: See note in `get length()`
     this._eventBufferItemLength++;
 
-    return promise as Promise<WorkerAddEventResponse>;
+    return promise;
   }
 
   /**
    * Finish the request and return the compressed data from the worker.
    */
   private async _finishRequest(id: number): Promise<Uint8Array> {
-    const promise = this._postMessage({ id, method: 'finish', args: [] });
+    const promise = this._postMessage<Uint8Array>({ id, method: 'finish', args: [] });
 
     // XXX: See note in `get length()`
     this._eventBufferItemLength = 0;
 
-    return promise as Promise<Uint8Array>;
+    return promise;
   }
 
   /** Get the current ID and increment it for the next call. */

packages/replay/src/types.ts

@@ -51,7 +51,7 @@ export interface WorkerResponse {
   response: unknown;
 }
 
-export type WorkerAddEventResponse = boolean;
+export type WorkerAddEventResponse = void;
 
 export interface SampleRates {
   /**

packages/replay/worker/src/Compressor.ts

@@ -25,9 +25,9 @@ export class Compressor {
     return;
   }
 
-  public addEvent(data: Record<string, unknown>): boolean {
+  public addEvent(data: Record<string, unknown>): void {
     if (!data) {
-      return false;
+      throw new Error('Adding invalid event');
     }
     // If the event is not the first event, we need to prefix it with a `,` so
     // that we end up with a list of events
@@ -38,8 +38,6 @@ export class Compressor {
     this.deflate.push(prefix + JSON.stringify(data), constants.Z_SYNC_FLUSH);
 
     this.added++;
-
-    return true;
   }
 
   public finish(): Uint8Array {

packages/replay/worker/src/handleMessage.ts

@@ -47,7 +47,7 @@ export function handleMessage(e: MessageEvent): void {
         id,
         method,
         success: false,
-        response: err,
+        response: err.message,
       });
 
       // eslint-disable-next-line no-console