File tree Expand file tree Collapse file tree 3 files changed +3
-18
lines changed
packages/tracing-internal Expand file tree Collapse file tree 3 files changed +3
-18
lines changed Original file line number Diff line number Diff line change @@ -536,11 +536,11 @@ function setResourceEntrySizeData(
536536}
537537
538538/**
539- * Add ttfb information to measurements
539+ * Add ttfb request time information to measurements.
540540 *
541- * Exported for tests
541+ * ttfb information is added via vendored web vitals library.
542542 */
543- export function _addTtfbRequestTimeToMeasurements ( _measurements : Measurements ) : void {
543+ function _addTtfbRequestTimeToMeasurements ( _measurements : Measurements ) : void {
544544 const navEntry = getNavigationEntry ( ) as TTFBMetric [ 'entries' ] [ number ] ;
545545 const { responseStart, requestStart } = navEntry ;
546546
Original file line number Diff line number Diff line change @@ -54,4 +54,3 @@ https://github.com/getsentry/sentry-javascript/pull/9690
5454TODO
5555
5656- Add support for TTFB (Time to First Byte)
57-
Original file line number Diff line number Diff line change @@ -10,7 +10,6 @@ import {
1010} from '@sentry/core' ;
1111import type { Span } from '@sentry/types' ;
1212import type { ResourceEntry } from '../../../src/browser/metrics' ;
13- import { _addTtfbRequestTimeToMeasurements } from '../../../src/browser/metrics' ;
1413import { _addMeasureSpans , _addResourceSpans } from '../../../src/browser/metrics' ;
1514import { WINDOW } from '../../../src/browser/types' ;
1615import { TestClient , getDefaultClientOptions } from '../../utils/TestClient' ;
@@ -341,19 +340,6 @@ describe('_addResourceSpans', () => {
341340 } ) ;
342341} ) ;
343342
344- describe ( '_addTtfbRequestTimeToMeasurements' , ( ) => {
345- it ( 'adds ttfb.requestTime to measurements' , ( ) => {
346- const measurements = { } ;
347- _addTtfbRequestTimeToMeasurements ( measurements ) ;
348- expect ( measurements ) . toEqual ( {
349- 'ttfb.requestTime' : {
350- unit : 'millisecond' ,
351- value : 100000 ,
352- } ,
353- } ) ;
354- } ) ;
355- } ) ;
356-
357343const setGlobalLocation = ( location : Location ) => {
358344 // @ts -expect-error need to delete this in order to set to new value
359345 delete WINDOW . location ;
You can’t perform that action at this time.
0 commit comments