test fixes

Author: AbhiPrasad

dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-ttfb/test.ts

@@ -14,5 +14,7 @@ sentryTest('should capture TTFB vital.', async ({ getLocalTestPath, page }) => {
 
   expect(eventData.measurements).toBeDefined();
   expect(eventData.measurements?.ttfb?.value).toBeDefined();
+  expect(eventData.measurements?.ttfb?.value).toBeGreaterThan(0);
   expect(eventData.measurements?.['ttfb.requestTime']?.value).toBeDefined();
+  expect(eventData.measurements?.['ttfb.requestTime']?.value).toBeGreaterThan(0);
 });

packages/tracing-internal/test/browser/metrics/index.test.ts

@@ -10,7 +10,7 @@ import {
 } from '@sentry/core';
 import type { Span } from '@sentry/types';
 import type { ResourceEntry } from '../../../src/browser/metrics';
-import { _addTtfbToMeasurements } from '../../../src/browser/metrics';
+import { _addTtfbRequestTimeToMeasurements} from '../../../src/browser/metrics';
 import { _addMeasureSpans, _addResourceSpans } from '../../../src/browser/metrics';
 import { WINDOW } from '../../../src/browser/types';
 import { TestClient, getDefaultClientOptions } from '../../utils/TestClient';
@@ -341,32 +341,17 @@ describe('_addResourceSpans', () => {
   });
 });
 
-describe('_addTtfbToMeasurements', () => {
-  it('adds ttfb to measurements', () => {
+describe('_addTtfbRequestTimeToMeasurements', () => {
+  it('adds ttfb.requestTime to measurements', () => {
     const measurements = {};
-    _addTtfbToMeasurements(measurements, 300, 200, 100);
+    _addTtfbRequestTimeToMeasurements(measurements);
     expect(measurements).toEqual({
-      ttfb: {
-        unit: 'millisecond',
-        value: 200000,
-      },
       'ttfb.requestTime': {
         unit: 'millisecond',
         value: 100000,
       },
     });
   });
-
-  it('does not add negative ttfb', () => {
-    const measurements = {};
-    _addTtfbToMeasurements(measurements, 100, 200, 300);
-    expect(measurements).toEqual({
-      ttfb: {
-        unit: 'millisecond',
-        value: 0,
-      },
-    });
-  });
 });
 
 const setGlobalLocation = (location: Location) => {