update which ember envs are tested on CI

1. When running "normal" tests, only run for pinned version of ember.
2. When running on CI, test pinned version, 4.0, release & embroider.
3. Run `yarn test:all` to test all CI versions locally

Author: mydea

.github/workflows/build.yml

@@ -390,7 +390,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        scenario: [ember-release, ember-beta, ember-classic, ember-4.0]
+        scenario: [ember-release, embroider-optimized, ember-4.0]
     steps:
       - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
         uses: actions/checkout@v3

packages/ember/config/ember-try.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const getChannelURL = require('ember-source-channel-url');
-const { embroiderSafe } = require('@embroider/test-setup');
+const { embroiderOptimized } = require('@embroider/test-setup');
 
 /**
  * Pick which versions of ember against which to test based on whether the tests are running locally, as part of a PR,
@@ -19,50 +19,41 @@ module.exports = async function () {
           'ember-source': await getChannelURL('release'),
         },
       },
-      allowedToFail: true,
     },
-  ];
-
-  // in CI we add a few more tests - LTS and embroider (which is an ember compiler)
-  if (process.env.GITHUB_ACTIONS) {
-    scenarios = scenarios.concat([
-      {
-        name: 'ember-4.0',
-        npm: {
-          devDependencies: {
-            'ember-source': '~4.0.1',
-          },
+    {
+      name: 'ember-4.0',
+      npm: {
+        devDependencies: {
+          'ember-source': '~4.0.1',
         },
       },
-      embroiderSafe(),
-    ]);
-    scenarios = scenarios.concat([
-      {
-        name: 'ember-beta',
-        npm: {
-          devDependencies: {
-            'ember-source': await getChannelURL('beta'),
-          },
+    },
+    embroiderOptimized(),
+    {
+      name: 'ember-beta',
+      npm: {
+        devDependencies: {
+          'ember-source': await getChannelURL('beta'),
         },
-        allowedToFail: true,
       },
-      {
-        name: 'ember-classic',
-        env: {
-          EMBER_OPTIONAL_FEATURES: JSON.stringify({
-            'application-template-wrapper': true,
-            'default-async-observers': false,
-            'template-only-glimmer-components': false,
-          }),
-        },
-        npm: {
-          ember: {
-            edition: 'classic',
-          },
+      allowedToFail: true,
+    },
+    {
+      name: 'ember-classic',
+      env: {
+        EMBER_OPTIONAL_FEATURES: JSON.stringify({
+          'application-template-wrapper': true,
+          'default-async-observers': false,
+          'template-only-glimmer-components': false,
+        }),
+      },
+      npm: {
+        ember: {
+          edition: 'classic',
         },
       },
-    ]);
-  }
+    },
+  ];
 
   return {
     useYarn: true,

packages/ember/package.json

@@ -26,10 +26,8 @@
     "lint:js": "eslint . --cache --cache-location '../../eslintcache/'",
     "lint:ts": "tsc",
     "start": "ember serve",
-    "test:ember": "ember test",
-    "test:ember-all": "ember try:each",
-    "test": "npm-run-all --print-name \"lint\" \"test:*\"",
-    "test:all": "node ./scripts/run-CI-tests.js",
+    "test": "ember test",
+    "test:all": "ember try:each",
     "prepack": "ember ts:precompile",
     "postpack": "ember ts:clean"
   },