Fix ember linting/type issues

Author: mydea

packages/ember/package.json

@@ -21,14 +21,17 @@
     "build:extras": "yarn build",
     "build:npm": "ember ts:precompile && npm pack && ember ts:clean",
     "clean": "yarn rimraf sentry-ember-*.tgz",
-    "lint": "npm-run-all --print-name --aggregate-output --continue-on-error --parallel \"lint:!(fix)\"",
+    "lint": "run-s lint:js lint:hbs lint:ts",
     "lint:hbs": "ember-template-lint .",
     "lint:js": "eslint . --cache --cache-location '../../eslintcache/'",
+    "lint:ts": "tsc",
     "start": "ember serve",
     "test:ember": "ember test",
     "test:ember-all": "ember try:each",
     "test": "npm-run-all --print-name \"lint\" \"test:*\"",
-    "test:all": "node ./scripts/run-CI-tests.js"
+    "test:all": "node ./scripts/run-CI-tests.js",
+    "prepack": "ember ts:precompile",
+    "postpack": "ember ts:clean"
   },
   "dependencies": {
     "@embroider/macros": "^1.9.0",
@@ -39,7 +42,7 @@
     "ember-auto-import": "^1.12.1 || ^2.4.3",
     "ember-cli-babel": "^7.26.11",
     "ember-cli-htmlbars": "^6.1.1",
-    "ember-cli-typescript": "^4.2.1"
+    "ember-cli-typescript": "^5.1.1"
   },
   "devDependencies": {
     "@ember/optional-features": "~1.3.0",
@@ -78,6 +81,7 @@
     "loader.js": "~4.7.0",
     "qunit": "~2.19.2",
     "qunit-dom": "~2.0.0",
+    "typescript": "~4.5.2",
     "webpack": "~5.74.0"
   },
   "engines": {

packages/ember/tests/acceptance/sentry-errors-test.js

@@ -39,6 +39,8 @@ module('Acceptance | Sentry Errors', function (hooks) {
   setupSentryTest(hooks);
 
   test('Check "Throw Generic Javascript Error"', async function (assert) {
+    assert.expect(3);
+
     await visit('/');
     const button = find('[data-test-button="Throw Generic Javascript Error"]');
 
@@ -49,6 +51,8 @@ module('Acceptance | Sentry Errors', function (hooks) {
   });
 
   test('Check "Throw EmberError"', async function (assert) {
+    assert.expect(3);
+
     await visit('/');
     const button = find('[data-test-button="Throw EmberError"]');
 
@@ -59,6 +63,8 @@ module('Acceptance | Sentry Errors', function (hooks) {
   });
 
   test('Check "Caught Thrown EmberError"', async function (assert) {
+    assert.expect(1);
+
     await visit('/');
     const button = find('[data-test-button="Caught Thrown EmberError"]');
 
@@ -68,6 +74,8 @@ module('Acceptance | Sentry Errors', function (hooks) {
   });
 
   test('Check "Error From Fetch"', async function (assert) {
+    assert.expect(3);
+
     this.fetchStub.onFirstCall().callsFake((...args) => {
       return this.fetchStub.callsThrough(args);
     });
@@ -86,6 +94,8 @@ module('Acceptance | Sentry Errors', function (hooks) {
   });
 
   test('Check "Error in AfterRender"', async function (assert) {
+    assert.expect(4);
+
     await visit('/');
     const button = find('[data-test-button="Error in AfterRender"]');
 
@@ -97,6 +107,8 @@ module('Acceptance | Sentry Errors', function (hooks) {
   });
 
   test('Check "RSVP Rejection"', async function (assert) {
+    assert.expect(4);
+
     await visit('/');
     const button = find('[data-test-button="RSVP Rejection"]');
 
@@ -108,6 +120,8 @@ module('Acceptance | Sentry Errors', function (hooks) {
   });
 
   test('Check "Error inside RSVP"', async function (assert) {
+    assert.expect(4);
+
     await visit('/');
     const button = find('[data-test-button="Error inside RSVP"]');
 

packages/ember/tests/acceptance/sentry-performance-test.js

@@ -53,6 +53,8 @@ module('Acceptance | Sentry Performance', function (hooks) {
   setupSentryTest(hooks);
 
   test('Test transaction', async function (assert) {
+    assert.expect(6);
+
     await visit('/tracing');
 
     assertSentryTransactionCount(assert, 1);
@@ -75,6 +77,8 @@ module('Acceptance | Sentry Performance', function (hooks) {
   });
 
   test('Test navigating to slow route', async function (assert) {
+    assert.expect(7);
+
     await visit('/tracing');
     const button = find('[data-test-button="Transition to slow loading route"]');
 

packages/ember/tests/dummy/app/controllers/slow-loading-route/index.js

@@ -1,9 +1,5 @@
 import Controller from '@ember/controller';
-import { computed } from '@ember/object';
 
 export default class SlowLoadingRouteController extends Controller {
-  @computed()
-  get slowLoadingTemplateOnlyItems() {
-    return new Array(2000).fill(0).map((_, index) => index);
-  }
+  slowLoadingTemplateOnlyItems = new Array(2000).fill(0).map((_, index) => index);
 }

packages/ember/tests/helpers/setup-sentry.js

@@ -13,6 +13,7 @@ export function setupSentryTest(hooks) {
     const errorMessages = [];
     this.errorMessages = errorMessages;
 
+    // eslint-disable-next-line ember/no-private-routing-service
     const routerMain = this.owner.lookup('router:main');
     const routerService = this.owner.lookup('service:router');
 

yarn.lock

@@ -11094,10 +11094,10 @@ ember-cli-typescript@^2.0.2:
     stagehand "^1.0.0"
     walk-sync "^1.0.0"
 
-ember-cli-typescript@^4.2.1:
-  version "4.2.1"
-  resolved "https://registry.yarnpkg.com/ember-cli-typescript/-/ember-cli-typescript-4.2.1.tgz#54d08fc90318cc986f3ea562f93ce58a6cc4c24d"
-  integrity sha512-0iKTZ+/wH6UB/VTWKvGuXlmwiE8HSIGcxHamwNhEC5x1mN3z8RfvsFZdQWYUzIWFN2Tek0gmepGRPTwWdBYl/A==
+ember-cli-typescript@^5.1.1:
+  version "5.1.1"
+  resolved "https://registry.yarnpkg.com/ember-cli-typescript/-/ember-cli-typescript-5.1.1.tgz#cf561026f3e7bd05312c1c212acffa1c30d5fa0c"
+  integrity sha512-DbzATYWY8nbXwSxXqtK8YlqGJTcyFyL+eg6IGCc2ur0AMnq/H+o6Z9np9eGoq1sI+HwX7vBkOVoD3k0WurAwXg==
   dependencies:
     ansi-to-html "^0.6.15"
     broccoli-stew "^3.0.0"
@@ -24626,6 +24626,11 @@ typescript@~4.0.2:
   resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.0.8.tgz#5739105541db80a971fdbd0d56511d1a6f17d37f"
   integrity sha512-oz1765PN+imfz1MlZzSZPtC/tqcwsCyIYA8L47EkRnRW97ztRk83SzMiWLrnChC0vqoYxSU1fcFUDA5gV/ZiPg==
 
+typescript@~4.5.2:
+  version "4.5.5"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.5.5.tgz#d8c953832d28924a9e3d37c73d729c846c5896f3"
+  integrity sha512-TCTIul70LyWe6IJWT8QSYeA54WQe8EjQFU4wY52Fasj5UKx88LNYKCgBEHcOMOrFF1rKGbD8v/xcNWVUq9SymA==
+
 ua-parser-js@^0.7.18, ua-parser-js@^0.7.30:
   version "0.7.31"
   resolved "https://registry.yarnpkg.com/ua-parser-js/-/ua-parser-js-0.7.31.tgz#649a656b191dffab4f21d5e053e27ca17cbff5c6"