Skip to content

Conversation

@adinauer
Copy link
Member

#skip-changelog

📜 Description

Add e2e tests for Spring 7 sample

💡 Motivation and Context

More coverage

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against fab72c4

@adinauer adinauer marked this pull request as ready for review September 25, 2025 13:55
cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 396.52 ms 507.74 ms 111.22 ms
Size 1.58 MiB 2.10 MiB 533.40 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c8125f3 397.65 ms 485.14 ms 87.49 ms
ee747ae 386.94 ms 431.43 ms 44.49 ms
23d6b12 354.10 ms 408.38 ms 54.28 ms
d217708 409.83 ms 474.72 ms 64.89 ms
d217708 411.22 ms 430.86 ms 19.63 ms
ee747ae 400.46 ms 423.61 ms 23.15 ms
17a0955 372.53 ms 446.70 ms 74.17 ms
3d205d0 352.15 ms 432.53 ms 80.38 ms
1df7eb6 397.04 ms 429.64 ms 32.60 ms
b750b96 408.98 ms 480.32 ms 71.34 ms

App size

Revision Plain With Sentry Diff
c8125f3 1.58 MiB 2.10 MiB 532.32 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
23d6b12 1.58 MiB 2.10 MiB 532.31 KiB
d217708 1.58 MiB 2.10 MiB 532.97 KiB
d217708 1.58 MiB 2.10 MiB 532.97 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
17a0955 1.58 MiB 2.10 MiB 533.20 KiB
3d205d0 1.58 MiB 2.10 MiB 532.97 KiB
1df7eb6 1.58 MiB 2.10 MiB 532.97 KiB
b750b96 1.58 MiB 2.10 MiB 533.19 KiB

Previous results on branch: feat/spring-7-e2e-test

Startup times

Revision Plain With Sentry Diff
5ced2b7 382.73 ms 414.15 ms 31.41 ms

App size

Revision Plain With Sentry Diff
5ced2b7 1.58 MiB 2.10 MiB 532.97 KiB

@adinauer adinauer merged commit d478d66 into main Sep 26, 2025
45 of 46 checks passed
@adinauer adinauer deleted the feat/spring-7-e2e-test branch September 26, 2025 10:08
require(this is Test)

filter { excludeTestsMatching("io.sentry.systemtest.*") }
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: JUnit 5 Tests Fail Without Platform Configuration

The global useJUnitPlatform() configuration was removed, but it's required for JUnit 5 tests to run. Both the test and systemTest tasks are missing this configuration, which prevents JUnit 5 tests from executing properly.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants