Compress Screenshots on a background thread #4295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markushi
requested review from
adinauer,
lcian,
romtsn and
stefanosiano
as code owners
Contributor
Performance metrics 🚀
|
markushi
commented
Mar 28, 2025
| try (final ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream()) { | ||
| // 0 meaning compress for small size, 100 meaning compress for max quality. | ||
| // Some formats, like PNG which is lossless, will ignore the quality setting. | ||
| bitmap.compress(Bitmap.CompressFormat.PNG, 0, byteArrayOutputStream); |
Member
Author
There was a problem hiding this comment.
It's worth mentioning that we never call bitmap.recycle() - and we also didn't do before. But I guess it makes sense to do so!
Member
There was a problem hiding this comment.
yeah, since we also create a new bitmap for every new screenshot we should probably recycle 😅
romtsn
pushed a commit
that referenced
this pull request
Jul 8, 2025
* Compress Screenshots on a background thread * Update Changelog * Recover APIs used by hybrid SDKs * Recycle bitmap after compression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixes #3647
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps