Skip to content

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Jan 8, 2025

#skip-changelog

📜 Description

Merge main into 8.x.x with 7.20.0 being latest release

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java
  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c34b5b7

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 427.15 ms 516.33 ms 89.18 ms
Size 1.65 MiB 2.31 MiB 677.52 KiB

Previous results on branch: feat/merge-main-jan-2025

Startup times

Revision Plain With Sentry Diff
9c294ec 425.75 ms 461.96 ms 36.21 ms

App size

Revision Plain With Sentry Diff
9c294ec 1.65 MiB 2.31 MiB 677.64 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java
  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving the replay changes ✅

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java
  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the other changes

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java
  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

@adinauer adinauer merged commit cb4efff into 8.x.x Jan 9, 2025
35 of 36 checks passed
@adinauer adinauer deleted the feat/merge-main-jan-2025 branch January 9, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants