Skip to content

Conversation

@adinauer
Copy link
Member

#skip-changelog

📜 Description

Speed up tests by reducing shutdownTimeout

💡 Motivation and Context

By globally setting the default to 0 we could save another couple of minutes on the build with tests (14m vs 21m).

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 038526f

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 379.53 ms 429.86 ms 50.33 ms
Size 1.65 MiB 2.31 MiB 676.08 KiB

Previous results on branch: feat/speed-up-some-tests

Startup times

Revision Plain With Sentry Diff
917b641 382.94 ms 406.64 ms 23.70 ms

App size

Revision Plain With Sentry Diff
917b641 1.65 MiB 2.31 MiB 676.08 KiB

@adinauer adinauer merged commit a56b3bc into 8.x.x Dec 19, 2024
33 of 35 checks passed
@adinauer adinauer deleted the feat/speed-up-some-tests branch December 19, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants