-
-
Couldn't load subscription status.
- Fork 460
Close backpressure monitor on SDK shutdown #3998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…the ScopesStorage is initialized
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Close backpressure monitor on SDK shutdown ([#3998](https://github.com/getsentry/sentry-java/pull/3998))If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 33c9aac | 393.47 ms | 407.26 ms | 13.79 ms |
| b387fed | 417.02 ms | 519.06 ms | 102.04 ms |
| c658b5a | 410.55 ms | 461.18 ms | 50.63 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 33c9aac | 1.65 MiB | 2.31 MiB | 677.05 KiB |
| b387fed | 1.65 MiB | 2.31 MiB | 677.07 KiB |
| c658b5a | 1.65 MiB | 2.31 MiB | 677.05 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
📜 Description
Close backpressure monitor on SDK shutdown
💡 Motivation and Context
Due to the backpressure monitor rescheduling a task at 10s intervals, there's a very high chance of a task currently being scheduled at any time that takes longer than the
shutdownTimeoutMillis(defaulting to 2s) before it'll run. When the SDK shuts down, it'll first ask theScheduledExecutorServiceto shutdown, not accepting any more new scheduled jobs but giving already scheduled jobs a chance to run. This means the SDK shutdown will almost always be delayed by the backpressure monitors scheduled job before it forcefully shuts downScheduledExecutorServiceafter waitingshutdownTimeoutMillis💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps