-
-
Notifications
You must be signed in to change notification settings - Fork 461
POTEL 67 - Add openTelemetryMode option
#3994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 25b4e26 | 375.50 ms | 426.00 ms | 50.50 ms |
| 75859e1 | 405.08 ms | 466.24 ms | 61.16 ms |
| a58d1ae | 404.23 ms | 424.78 ms | 20.55 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 25b4e26 | 1.65 MiB | 2.31 MiB | 676.61 KiB |
| 75859e1 | 1.65 MiB | 2.31 MiB | 676.61 KiB |
| a58d1ae | 1.65 MiB | 2.31 MiB | 676.57 KiB |
| options.setEnableExternalConfiguration(true); | ||
| options.setInitPriority(InitPriority.HIGH); | ||
| OpenTelemetryUtil.applyOpenTelemetryOptions(options, SentryOpenTelemetryMode.AGENT); | ||
| options.setOpenTelemetryMode(SentryOpenTelemetryMode.AGENT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we leave that on AUTO here and let the OpenTelemetryUtils decide?
The SentryAutoConfigurationCustomizerProvider is also present in the sentry-opentelemetry-agentless case and if a SENTRY_PROPERTIES_FILE or SENTRY_DSN environment variable is present, it would auto-init unless skipInit is specifically set like in SentryOpenTelemetryNoAgentConfiguration for Spring integrations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
📜 Description
Add
openTelemetryModeoption💡 Motivation and Context
So customers don't have to add
OpenTelemetryUtil.apply...to their applications and instead have the SDK figure out automatically in what way to use OpenTelemetry.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
OFFenum option but that would require us to initializeScopesStoragelater to first read the option and only then initialize it. It would have to be NOOP before.