Skip to content

Conversation

@adinauer
Copy link
Member

📜 Description

Replace bool with enum for OpenTelemetryUtil mode

💡 Motivation and Context

The bool did not allow us to distinguish between agentless with or without spring. The distinction is needed as the opentelemetry-spring-boot-starter has some of the auto instrumentation available.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- POTEL 65 - Replace bool with enum for `OpenTelemetryUtil` mode ([#3988](https://github.com/getsentry/sentry-java/pull/3988))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 33877cc

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 416.04 ms 430.04 ms 14.00 ms
Size 1.65 MiB 2.31 MiB 676.08 KiB

Previous results on branch: feat/otelutil-mode

Startup times

Revision Plain With Sentry Diff
cd7ef18 421.81 ms 471.44 ms 49.63 ms
f7eeba8 438.38 ms 475.12 ms 36.74 ms

App size

Revision Plain With Sentry Diff
cd7ef18 1.65 MiB 2.31 MiB 676.08 KiB
f7eeba8 1.65 MiB 2.31 MiB 676.08 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , barring some open questions on whether we can get rid of that OpenTelemetryUtil.applyOpenTelemetryOptions call altogether

Base automatically changed from feat/agentless-module to 8.x.x December 17, 2024 09:57
@adinauer adinauer merged commit 09fce1c into 8.x.x Dec 17, 2024
26 of 30 checks passed
@adinauer adinauer deleted the feat/otelutil-mode branch December 17, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants