Skip to content

DisabledQueue.isEmpty now returns true #3927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2024
Merged

DisabledQueue.isEmpty now returns true #3927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05185f5
DisabledQueue.isEmpty now returns true
stefanosiano Nov 25, 2024
3217493
Merge branch '8.x.x' into fix/disabled-queue-empty-true
stefanosiano Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sentry/src/main/java/io/sentry/DisabledQueue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public int size() {
*/
@Override
public boolean isEmpty() {
return false;
return true;
}

/** Does nothing. */
Expand Down
9 changes: 5 additions & 4 deletions sentry/src/test/java/io/sentry/DisabledQueueTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import kotlin.test.Test
import kotlin.test.assertEquals
import kotlin.test.assertFalse
import kotlin.test.assertNull
import kotlin.test.assertTrue

class DisabledQueueTest {

Expand All @@ -22,17 +23,17 @@ class DisabledQueueTest {
}

@Test
fun `isEmpty returns false when created`() {
fun `isEmpty returns true when created`() {
val queue = DisabledQueue<Int>()
assertFalse(queue.isEmpty(), "isEmpty should always return false.")
assertTrue(queue.isEmpty(), "isEmpty should always return true.")
}

@Test
fun `isEmpty always returns false if add function was called`() {
fun `isEmpty always returns true if add function was called`() {
val queue = DisabledQueue<Int>()
queue.add(1)

assertFalse(queue.isEmpty(), "isEmpty should always return false.")
assertTrue(queue.isEmpty(), "isEmpty should always return true.")
}

@Test
Expand Down
Loading