Skip to content

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Oct 28, 2024

📜 Description

  • Add a new sample sentry-samples-spring-boot-jakarta-opentelemetry to showcase combining Sentry and OpenTelemetry
  • Improve tests to no longer only check for number of envelopes received by relay but instead actually assert the content (e.g. a transaction with a certain op, or a transaction that has a span with a certain op)

Also has a fix for ignoring spans created by the GraphQL v22 integration. Also fixes the Spring Boot 3 WebFlux sample to use GraphQL v22.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 777173a

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 641.66 ms 709.84 ms 68.18 ms
Size 1.70 MiB 2.36 MiB 671.42 KiB

Previous results on branch: feat/extend-backend-e2e-tests

Startup times

Revision Plain With Sentry Diff
5942657 397.92 ms 417.90 ms 19.98 ms
3226143 408.83 ms 452.96 ms 44.13 ms
dc8178c 404.79 ms 432.84 ms 28.06 ms
9a21ffe 428.26 ms 448.80 ms 20.54 ms
1732412 378.67 ms 457.52 ms 78.85 ms
e1dbabf 411.02 ms 415.20 ms 4.18 ms
42e3a25 485.09 ms 551.70 ms 66.61 ms

App size

Revision Plain With Sentry Diff
5942657 1.70 MiB 2.36 MiB 671.41 KiB
3226143 1.70 MiB 2.36 MiB 671.41 KiB
dc8178c 1.70 MiB 2.36 MiB 671.42 KiB
9a21ffe 1.70 MiB 2.36 MiB 671.41 KiB
1732412 1.70 MiB 2.36 MiB 671.41 KiB
e1dbabf 1.70 MiB 2.36 MiB 671.41 KiB
42e3a25 1.70 MiB 2.36 MiB 671.41 KiB

@adinauer adinauer merged commit c682d68 into 8.x.x Oct 30, 2024
23 checks passed
@adinauer adinauer deleted the feat/extend-backend-e2e-tests branch October 30, 2024 05:31
@@ -0,0 +1,122 @@
# Sentry Sample Spring Boot 3.0+
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentry Sample Spring Boot 3.0+ and OpenTelemetry

@@ -0,0 +1,122 @@
# Sentry Sample Spring Boot 3.0+

Sample application showing how to use Sentry with [Spring boot](http://spring.io/projects/spring-boot) from version `3.0` onwards.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to add the fact, that this is a sample including OTEL, something like:
Sample application showing how to use Sentry with Spring boot from version 3.0 onwards and OpenTelemetry.

Also, we might want to add some guidance on how to add the otel agent in the readme wdyt?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also add some instructions on how to run the system-tests locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants