-
-
Notifications
You must be signed in to change notification settings - Fork 461
Extend backend e2e tests #3828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend backend e2e tests #3828
Conversation
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5942657 | 397.92 ms | 417.90 ms | 19.98 ms |
| 3226143 | 408.83 ms | 452.96 ms | 44.13 ms |
| dc8178c | 404.79 ms | 432.84 ms | 28.06 ms |
| 9a21ffe | 428.26 ms | 448.80 ms | 20.54 ms |
| 1732412 | 378.67 ms | 457.52 ms | 78.85 ms |
| e1dbabf | 411.02 ms | 415.20 ms | 4.18 ms |
| 42e3a25 | 485.09 ms | 551.70 ms | 66.61 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5942657 | 1.70 MiB | 2.36 MiB | 671.41 KiB |
| 3226143 | 1.70 MiB | 2.36 MiB | 671.41 KiB |
| dc8178c | 1.70 MiB | 2.36 MiB | 671.42 KiB |
| 9a21ffe | 1.70 MiB | 2.36 MiB | 671.41 KiB |
| 1732412 | 1.70 MiB | 2.36 MiB | 671.41 KiB |
| e1dbabf | 1.70 MiB | 2.36 MiB | 671.41 KiB |
| 42e3a25 | 1.70 MiB | 2.36 MiB | 671.41 KiB |
| @@ -0,0 +1,122 @@ | |||
| # Sentry Sample Spring Boot 3.0+ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sentry Sample Spring Boot 3.0+ and OpenTelemetry
| @@ -0,0 +1,122 @@ | |||
| # Sentry Sample Spring Boot 3.0+ | |||
|
|
|||
| Sample application showing how to use Sentry with [Spring boot](http://spring.io/projects/spring-boot) from version `3.0` onwards. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to add the fact, that this is a sample including OTEL, something like:
Sample application showing how to use Sentry with Spring boot from version 3.0 onwards and OpenTelemetry.
Also, we might want to add some guidance on how to add the otel agent in the readme wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also add some instructions on how to run the system-tests locally
📜 Description
sentry-samples-spring-boot-jakarta-opentelemetryto showcase combining Sentry and OpenTelemetryop, or a transaction that has a span with a certainop)Also has a fix for ignoring spans created by the GraphQL v22 integration. Also fixes the Spring Boot 3 WebFlux sample to use GraphQL v22.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps