Skip to content

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Oct 2, 2024

#skip-changelog

📜 Description

Support graphql-java v22 in Sentry Spring (Boot) integrations

💡 Motivation and Context

Pt. 2 of fixing #3737

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 1dddc78

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 382.17 ms 440.27 ms 58.10 ms
Size 1.70 MiB 2.35 MiB 669.06 KiB

Previous results on branch: feat/spring-support-graphql-v22

Startup times

Revision Plain With Sentry Diff
6898162 432.29 ms 439.60 ms 7.31 ms
d70d280 446.92 ms 475.84 ms 28.92 ms

App size

Revision Plain With Sentry Diff
6898162 1.70 MiB 2.35 MiB 669.06 KiB
d70d280 1.70 MiB 2.35 MiB 669.06 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feat/sentry-instrumentation-bean-instead-of-customizer to 8.x.x October 7, 2024 13:20
An error occurred while trying to automatically change base from feat/sentry-instrumentation-bean-instead-of-customizer to 8.x.x October 7, 2024 13:20
@adinauer adinauer merged commit 2065d35 into 8.x.x Oct 7, 2024
18 of 20 checks passed
@adinauer adinauer deleted the feat/spring-support-graphql-v22 branch October 7, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants