POTEL 21 - Drop OpenTelemetry spans for internal Sentry requests #3508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes-merge-2-add-scopes
…ainScopes to rootScopes
Contributor
|
Contributor
Performance metrics 🚀
|
lbloder
reviewed
Jun 24, 2024
| if (containsSpotlightUrl(httpUrl, spotlightUrl)) { | ||
| return true; | ||
| } | ||
| // } |
Collaborator
There was a problem hiding this comment.
Leftover that can be deleted
Member
Author
There was a problem hiding this comment.
Ideally we reintroduce the if above, then it's needed again. We can retest after doing the alpha release.
| return isTimedOut; | ||
| } | ||
|
|
||
| private @NotNull List<SpanData> filterOutSentrySpans(final @NotNull Collection<SpanData> spans) { |
Collaborator
There was a problem hiding this comment.
Are there instances where SentrySampler is not invoked and spans need to be filtered here in the exporter?
Member
Author
There was a problem hiding this comment.
Theoretically it's possible the span is modified during runtime and then has different attributes in SpanExporter.
Base automatically changed from
feat/potel-20-start-timestamp-sentry-span
to
8.x.x
June 24, 2024 12:20
lbloder
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
Requests to Sentry cause OpenTelemetry auto instrumentation to create spans. We now drop them in
SentrySamplerusingSamplingDecision.DROP.💡 Motivation and Context
#3499
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps